Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/kv): KvU64#valueOf and KvU64 inspect #18656

Merged
merged 4 commits into from
May 3, 2023

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Apr 11, 2023

new Deno.KvU64(1n) + 2n == 3n is now true.

new Deno.KvU64(1n) is now inspected as [Deno.KvU64: 1n] (Object(1n) is
inspected as [BigInt: 1n]).

@lucacasonato lucacasonato requested a review from losfair April 11, 2023 15:13
@lucacasonato lucacasonato force-pushed the kv_u64_valueof_and_inspect branch from dc0e7a8 to 4e7106e Compare May 1, 2023 15:34
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ext/kv/01_db.ts Outdated Show resolved Hide resolved
ext/kv/01_db.ts Outdated Show resolved Hide resolved
ext/kv/01_db.ts Show resolved Hide resolved
ext/kv/01_db.ts Outdated Show resolved Hide resolved
@bartlomieju bartlomieju enabled auto-merge (squash) May 3, 2023 11:09
@bartlomieju bartlomieju merged commit 93a78d3 into denoland:main May 3, 2023
@lucacasonato lucacasonato deleted the kv_u64_valueof_and_inspect branch May 4, 2023 12:39
levex pushed a commit that referenced this pull request May 4, 2023
`new Deno.KvU64(1n) + 2n == 3n` is now true.

`new Deno.KvU64(1n)` is now inspected as `[Deno.KvU64: 1n]`
(`Object(1n)` is inspected as `[BigInt: 1n]`).

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants