Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KV Feedback]: Visits counter example does not match actual #375

Closed
1 task done
sylc opened this issue May 1, 2023 · 2 comments
Closed
1 task done

[KV Feedback]: Visits counter example does not match actual #375

sylc opened this issue May 1, 2023 · 2 comments
Labels
kv Feedback about Deno KV

Comments

@sylc
Copy link

sylc commented May 1, 2023

🔍

  • Did you search for existing issues?

Type of feedback

Documentation improvement

Description

example provided at https://deno.com/kv does not fully work.

example provided
image
Expect results: Visits: 1

Actual:
image

Steps to reproduce (if applicable)

No response

Expected behavior (if applicable)

Example match actual

Possible solution (if applicable)

update example with:

- return new Response(`Visits: ${res.value}`)
+ return new Response(`Visits: ${res.value.value}`)

Additional context

No response

@sylc sylc added the kv Feedback about Deno KV label May 1, 2023
@ry
Copy link
Member

ry commented May 1, 2023

Oops, we're waiting for denoland/deno#18656 to land which will make res.value work.

@sylc
Copy link
Author

sylc commented May 16, 2023

This has been fixed

@sylc sylc closed this as completed May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kv Feedback about Deno KV
Projects
None yet
Development

No branches or pull requests

2 participants