fix(network): adjust Listener type params

[jodinathan]

fixes #18635

[CLAassistant]

All committers have signed the CLA.

[bartlomieju]

I'm marking this as "Request changes" because this PR changes types of the public stable Deno APIs that might have big impact on users. We need to carefully check if this will cause any breakages and if so we should line this change for Deno 2.0 release.

[jodinathan]

@bartlomieju thanks.
We need this change so deno can run on some specific environments and TlsListener extending both Listener and AsyncIterable is seen as an error =\

[jodinathan]

were you able to check this?
it doesn't seem to be a breakable change

[bartlomieju]

Hey @jodinathan, sorry for a slow response. I haven't had a chance to verify it, I'll try to get someone to check it before the next minor release.

[nayeemrmn]

LGTM

Here's how I checked for breaking changes:

export interface Listener2<T extends Deno.Conn = Deno.Conn> extends AsyncIterable<T> {
  accept(): Promise<T>;
  close(): void;
  readonly addr: Deno.Addr;
  readonly rid: number;
  [Symbol.asyncIterator](): AsyncIterableIterator<T>;
  ref(): void;
  unref(): void;
}

export type TlsListener2 = Listener2<Deno.TlsConn>;

let a: Deno.Listener = eval("{}");
let b: Listener2 = eval("{}");
a = b;
b = a;
let c: Deno.TlsListener = eval("{}");
let d: TlsListener2 = eval("{}");
c = d;
d = c;

// No type checking errors on the assignments. Types are equivalent.

[bartlomieju]

LGTM, thanks @jodinathan

[jodinathan]

was this published?

[bartlomieju]

Yes, this was published in Deno v1.37