We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Listener
Today the TlsListener extends Listener and AsyncIterable<TlsConn>. The problem is that Listener already extends AsyncIterable<Conn>:
TlsListener
AsyncIterable<TlsConn>
AsyncIterable<Conn>
export interface TlsListener extends Listener, AsyncIterable<TlsConn> { } export interface Listener extends AsyncIterable<Conn> { }
export interface TlsListener extends Listener, AsyncIterable<TlsConn> { }
export interface Listener extends AsyncIterable<Conn> { }
Can we change the Listener so it has a type param so then we can remove the AsyncIterable<TlsConn> from TlsListener?
ie:
export interface Listener<T extends Conn = Conn> extends AsyncIterable<T> {} export interface TlsListener extends Listener<TlsConn> {}
I would PR this but I couldn't find it in any d.ts file
d.ts
The text was updated successfully, but these errors were encountered:
Here! https://github.com/denoland/deno/blob/25aac6c7a8e015c24966168d0e3897849fefc68a/ext/net/lib.deno_net.d.ts
Sorry, something went wrong.
fix(network): adjust Listener type params (#18642)
d22a666
Fixes #18635
8b34936
Successfully merging a pull request may close this issue.
Today the
TlsListener
extendsListener
andAsyncIterable<TlsConn>
.The problem is that
Listener
already extendsAsyncIterable<Conn>
:export interface TlsListener extends Listener, AsyncIterable<TlsConn> { }
export interface Listener extends AsyncIterable<Conn> { }
Can we change the
Listener
so it has a type param so then we can remove theAsyncIterable<TlsConn>
fromTlsListener
?ie:
I would PR this but I couldn't find it in any
d.ts
fileThe text was updated successfully, but these errors were encountered: