refactor: make ParsedModule implement Sync
#11581
Conversation
| @@ -0,0 +1,53 @@ | |||
| // Copyright 2018-2021 the Deno authors. All rights reserved. MIT license. | |||
There was a problem hiding this comment.
This file is a straight extract out of mod.ts. I did a slight bit of cleanup in this PR as well.
| static TARGET: JscTarget = JscTarget::Es2020; | ||
|
|
||
| #[derive(Debug, Clone, Eq, PartialEq)] | ||
| pub struct Location { | ||
| pub filename: String, | ||
| pub specifier: String, |
There was a problem hiding this comment.
Renamed to specifier to align with elsewhere.
| @@ -452,21 +431,12 @@ fn flatten_comments( | |||
| comments.into_iter().flat_map(|el| el.1) | |||
| } | |||
|
|
|||
| pub fn lex( | |||
| specifier: &str, | |||
There was a problem hiding this comment.
This parameter is not necessary.
| .unwrap() | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This function is probably not as elegant as it could be.
There was a problem hiding this comment.
LGTM but a couple of brief comments.
Also, I think it is more of refactor: than a chore: (https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716)
| @@ -82,7 +82,7 @@ serde = { version = "1.0.126", features = ["derive"] } | |||
| shell-escape = "0.1.5" | |||
| sourcemap = "6.0.1" | |||
| swc_bundler = "0.46.0" | |||
| swc_common = { version = "0.11.0", features = ["sourcemap"] } | |||
| swc_common = { version = "0.11.4", features = ["sourcemap"] } | |||
There was a problem hiding this comment.
Is the version bump required for this PR? Normally we bump all the other uses of swc_common across the crates before a release.
There was a problem hiding this comment.
Yup. Need it for some changes I did in swc_common.
| use swc_common::comments::SingleThreadedCommentsMapInner; | ||
| use swc_common::BytePos; | ||
|
|
||
| #[derive(Clone, Debug)] |
There was a problem hiding this comment.
Not that it is a big deal, but future generations might benefit from a little explanation of why we are doing this?
ParsedModule implement SyncParsedModule implement Sync
5517fc5 to
7152928
Compare
|
@kitsonk thanks! Fixed. Sometimes I forget to do |
This PR is the first two points in #11345.
Basically, this change does two main things:
SourceMapandSourceFilein favour of the newSourceFileInfo, which implementsSync.SingleThreadedCommentsto a new immutableMultiThreadedComments.