You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Also, caching the swc parse of the module in the document info would be a good thing I think. That might take a bit more structuring of code. It is used in dependency analysis of the document as well as the test code lens and also use by the linting (though I don't know how easy it would be to send it to deno_lint without a bigger refactor of one or the other).
Steps:
Remove use of SourceMap and SourceFile in the code because they don't implement Send without turning on swc_common's concurrent feature, which is not something I want to do because then all the code will use locks internally (which we don't need... slower), open us up to a new class of possible bugs, and it's a global change.
Refactor code for transpiling and bundling to still use SourceMap & SourceFile as it is required by swc, but change the rest of the code not to use that.
Replace SingleThreadedComments implementation of Comments with a version that implements Send.
Store the ParsedModule in the document cache and use it throughout the code.
The text was updated successfully, but these errors were encountered:
I'm breaking this out of #11032
Steps:
SourceMap
andSourceFile
in the code because they don't implementSend
without turning onswc_common
'sconcurrent
feature, which is not something I want to do because then all the code will use locks internally (which we don't need... slower), open us up to a new class of possible bugs, and it's a global change.SourceMap/SourceFile
'sBytePos
-> Line and column that exists onParsedModule
.ParsedModule
in the step above might make most of this not required to complete this task)SourceMap
&SourceFile
as it is required by swc, but change the rest of the code not to use that.SingleThreadedComments
implementation ofComments
with a version that implementsSend
.ParsedModule
in the document cache and use it throughout the code.The text was updated successfully, but these errors were encountered: