Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine optimal tsconfig, update example configs to inherit from the optimized top level tsconfig (breaking changes) #2681

Merged
merged 28 commits into from
Feb 13, 2025
Merged

Determine optimal tsconfig, update example configs to inherit from the optimized top level tsconfig (breaking changes) #2681

Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
9f778b5
extend tsconfigs from base config
bdemann Feb 10, 2025
30b7ebe
extend tsconfigs from base config for non-trial tsconfigs
bdemann Feb 10, 2025
4fd6949
mix motoko example ts configs
bdemann Feb 10, 2025
391a0c9
update typecheck command verification
bdemann Feb 10, 2025
1a08590
remove config verification
bdemann Feb 10, 2025
e583fbc
try bundler
bdemann Feb 10, 2025
91ca3d8
exclude examples
bdemann Feb 11, 2025
9f1c36f
remove now unnecessary typecheck config
bdemann Feb 11, 2025
ae68b50
switch HACK_BECAUSE_OF_ALLOW_JS for noEmit
bdemann Feb 11, 2025
988cdcc
remove the need for tsconfigs in purely js canisters
bdemann Feb 12, 2025
3a4e40b
remove redundant --noEmit from typechecking commands
bdemann Feb 12, 2025
1ac88f7
update path for extended tsconfig
bdemann Feb 12, 2025
d9c479a
add back allowJS and noEmit
bdemann Feb 12, 2025
a0eac85
remove experimental decorators from those that don't need it
bdemann Feb 12, 2025
10ef74a
update new to use basic tsconfig
bdemann Feb 12, 2025
2770568
add tsconfig.jest.json to handle jest configuration needs
bdemann Feb 12, 2025
1fb7ed1
update default tsconfig for exbuildPluginTsc to be the simple dev config
bdemann Feb 12, 2025
e1e8bd3
fix encoding for reading in the tsconfig file
bdemann Feb 12, 2025
682c685
rename to examples
bdemann Feb 12, 2025
c8bd95f
fixup
bdemann Feb 12, 2025
8640a93
put back the target onto ii example
bdemann Feb 13, 2025
4bb9352
update new command
bdemann Feb 13, 2025
642a1a9
try removing skip lib check
bdemann Feb 13, 2025
4d4fc14
combine examples config with dev config so jest will work with new co…
bdemann Feb 13, 2025
bb5fabd
Merge branch 'main' into optimal_ts_config
bdemann Feb 13, 2025
87042ee
restore skipLibCheck for examples
bdemann Feb 13, 2025
89730a1
fix broken link
bdemann Feb 13, 2025
cc3851c
add back in double dash
bdemann Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions examples/experimental/demo/basic_bitcoin/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
{
"extends": "../../../../tsconfig.dev.json",
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS",
"allowSyntheticDefaultImports": true
}
}
7 changes: 1 addition & 6 deletions examples/experimental/demo/bitcoin_psbt/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
{
"extends": "../../../../tsconfig.dev.json",
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS",
"allowSyntheticDefaultImports": true
}
}
9 changes: 1 addition & 8 deletions examples/experimental/demo/ckbtc/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../tsconfig.dev.json"
}
7 changes: 1 addition & 6 deletions examples/experimental/demo/hello_world_http_server/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
{
"extends": "../../../../tsconfig.dev.json",
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS",
"allowSyntheticDefaultImports": true,
"experimentalDecorators": true
}
Expand Down
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/async_await/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/audio_recorder/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/bitcoin/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/blob_array/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/bytes/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/call_raw/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/candid_encoding/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/candid_keywords/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/canister/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/ckbtc/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/complex_init/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/complex_types/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/composite_queries/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/counter/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/cross_canister_calls/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/cycles/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/date/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
11 changes: 2 additions & 9 deletions examples/experimental/test/end_to_end/candid_rpc/ethereum_json_rpc/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS",
"allowSyntheticDefaultImports": true
}
"extends": "../../../../../../tsconfig.dev.json",
"compilerOptions": { "allowSyntheticDefaultImports": true }
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/func_types/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/heartbeat/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/ic_api/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/icrc/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/imports/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/init/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/inspect_message/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/key_value_store/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/ledger_canister/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
9 changes: 1 addition & 8 deletions examples/experimental/test/end_to_end/candid_rpc/list_of_lists/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"compilerOptions": {
"strict": true,
"target": "ES2024",
"module": "ES2022",
"moduleResolution": "node",
"allowJs": true,
"outDir": "HACK_BECAUSE_OF_ALLOW_JS"
}
"extends": "../../../../../../tsconfig.dev.json"
}
Loading
Loading