Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine optimal tsconfig, update example configs to inherit from the optimized top level tsconfig (breaking changes) #2681

Merged
merged 28 commits into from
Feb 13, 2025
Merged

Determine optimal tsconfig, update example configs to inherit from the optimized top level tsconfig (breaking changes) #2681

merged 28 commits into from
Feb 13, 2025

Conversation

bdemann
Copy link
Member

@bdemann bdemann commented Feb 10, 2025 •
edited by lastmjs
Loading

Contributor

  • Code has been declaratized
  • All new functions have JSDoc/Rustdoc comments
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • PR title:
    • Sentence cased
    • Described well for release notes
    • Indicates breaking changes with suffix "(breaking changes)"
  • Related issues have been linked and all tasks have been completed or made into separate issues
  • New documentation enumerated in the release issue
  • All breaking changes
    • Described below in the "Breaking Changes" section
    • Migration path described
  • Review is requested when ready

Reviewer

  • --skipLibCheck added back for example tests with TODO to the issue
  • new examples but work with an npm install, npm test
  • new examples have jest
  • get rid of tsconfig.examples.json
  • Code has been declaratized
  • All new functions have JSDoc/Rustdoc comments
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • PR title:
    • Sentence cased
    • Described well for release notes
    • Indicates breaking changes with suffix "(breaking changes)"
  • Related issues have been linked and all tasks have been completed or made into separate issues
  • New documentation enumerated in the release issue
  • All breaking changes
    • Described below in the "Breaking Changes" section
    • Migration path described

Breaking Changes

  • The tsconfig.json files for all of the examples have been updated and the old settings are no longer tested against and are not guaranteed to work. tsconfig.json files should be updated to reflect the settings in azle/tsconfig.dev.json

@bdemann bdemann changed the base branch from update_es_version to main February 10, 2025 22:52
@bdemann bdemann changed the title Optimal_ts_config Determine optimal tsconfig, update example configs to inherit from the top level tsconfig Feb 11, 2025
@bdemann bdemann changed the title Determine optimal tsconfig, update example configs to inherit from the top level tsconfig Determine optimal tsconfig, update example configs to inherit from the optimized top level tsconfig Feb 11, 2025
@bdemann bdemann linked an issue Feb 11, 2025 that may be closed by this pull request
Determine optimal tsconfig #2661
Closed
14 tasks
@bdemann bdemann requested a review from lastmjs February 11, 2025 18:29
@bdemann bdemann marked this pull request as ready for review February 11, 2025 18:29
@bdemann bdemann force-pushed the optimal_ts_config branch 2 times, most recently from d59edea to 549e55e Compare February 12, 2025 21:22
lastmjs
lastmjs requested changes Feb 13, 2025
View reviewed changes
tsconfig.dev.json Outdated Show resolved Hide resolved
src/build/stable/commands/new.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
examples/stable/test/property/ic_api/trap/tsconfig.json Outdated Show resolved Hide resolved
examples/stable/test/end_to_end/candid_rpc/outgoing_http_requests/tsconfig.json Show resolved Hide resolved
@lastmjs lastmjs enabled auto-merge February 13, 2025 18:39
lastmjs
lastmjs requested changes Feb 13, 2025
View reviewed changes
test/index.ts Outdated Show resolved Hide resolved
src/build/stable/commands/new.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
@lastmjs
Copy link
Member

lastmjs commented Feb 13, 2025

Please indicate breaking changes, let's consider the change in the tsconfig.json to be a breaking change?

@bdemann bdemann changed the title Determine optimal tsconfig, update example configs to inherit from the optimized top level tsconfig Determine optimal tsconfig, update example configs to inherit from the optimized top level tsconfig (breaking changes) Feb 13, 2025
lastmjs
lastmjs requested changes Feb 13, 2025
View reviewed changes
test/index.ts Outdated Show resolved Hide resolved
lastmjs
lastmjs previously approved these changes Feb 13, 2025
View reviewed changes
@lastmjs lastmjs merged commit d00cf91 into main Feb 13, 2025
377 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lastmjs lastmjs lastmjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Determine optimal tsconfig
2 participants
@bdemann @lastmjs