[Kernel] Use SLF4J for logging in kernel-api #2305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -356,31 +359,32 @@ protected Optional<LogSegment> getLogSegmentForVersion( | |||
| final List<FileStatus> checkpoints = checkpointsAndDeltas._1; | |||
| final List<FileStatus> deltas = checkpointsAndDeltas._2; | |||
|
|
|||
| logDebug(() -> | |||
| logger.atDebug().setMessage(() -> | |||
There was a problem hiding this comment.
what's this .setMessage API? I googled around but couldn't find it. Could you link to it? Does it just take a in a supplier?
There was a problem hiding this comment.
Yep, fluent logging API and java docs
scottsand-db
approved these changes
Nov 16, 2023
vkorukanti
approved these changes
Nov 20, 2023
| @@ -158,7 +161,7 @@ protected final Optional<List<FileStatus>> listDeltaAndCheckpointFiles( | |||
| TableClient tableClient, | |||
| long startVersion, | |||
| Optional<Long> versionToLoad) { | |||
| logDebug(String.format("startVersion: %s, versionToLoad: %s", startVersion, versionToLoad)); | |||
| logger.debug("startVersion: {}, versionToLoad{}", startVersion, versionToLoad); | |||
There was a problem hiding this comment.
nit:
Suggested change
| logger.debug("startVersion: {}, versionToLoad{}", startVersion, versionToLoad); | |
| logger.debug("startVersion: {}, versionToLoad {}", startVersion, versionToLoad); |
There was a problem hiding this comment.
nit: versionToLoad: {} (colon)
| @@ -227,7 +230,7 @@ private SnapshotImpl createSnapshot( | |||
| .checkpointVersionOpt | |||
| .map(v -> String.format(" starting from checkpoint version %s.", v)) | |||
| .orElse("."); | |||
| logInfo(() -> String.format("Loading version %s%s", initSegment.version, startingFromStr)); | |||
| logger.info("Loading version {}{}", initSegment.version, startingFromStr); | |||
There was a problem hiding this comment.
Suggested change
| logger.info("Loading version {}{}", initSegment.version, startingFromStr); | |
| logger.info("Loading version {} {}", initSegment.version, startingFromStr); |
| # limitations under the License. | ||
| # | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more |
There was a problem hiding this comment.
why do we need two licenses here?
There was a problem hiding this comment.
I copied these from connectors I'm assuming they were originally copied from Spark
| # limitations under the License. | ||
| # | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Resolves #2230
Uses SLF4J for logging in kernel-API. See #2230 for the decision doc on this.
Also adds log4j for logging in tests.
How was this patch tested?
Temporarily changed log level=DEBUG and ran tests in both kernelApi and kernelDefaults and confirmed that logs were outputted.