Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request][Kernel] Logging framework #2230

Closed
vkorukanti opened this issue Oct 24, 2023 · 1 comment
Closed

[Feature Request][Kernel] Logging framework #2230

vkorukanti opened this issue Oct 24, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request kernel
Milestone

Comments

@vkorukanti
Copy link
Collaborator

Feature request

Overview

Currently Kernel doesn't have any logging mechanism in the code to trace or debug issues. This issue is to add design and add a logging framework.

Further details

Contains notes on functionality, implementation, and testing decision questions gathered while building out the Delta Kernel. This is just to keep track of these points and not forget about them.

Requirements

  • Provide a way to trace the path taken by the Kernel API module for debugging functionality and performance issues.
    • Ex: Log the time before and after the call to get the schema. This helps debug any performance issues with fetching the initial schema.
  • Kernel-API module shouldn’t decide where the logs should go. It should be the responsibility of the TableClient, but this raises a few questions
    • Where should the Logging API be?
    • How can we generate a per-class Logger just like SLF4J?
    • Or should the Kernel-API depend on SLF4J?

High-level tasks

Depends on solving the above design questions

@allisonport-db
Copy link
Collaborator

Decision doc here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kernel
Projects
Development

Successfully merging a pull request may close this issue.

2 participants