fix(karma): Fix issue regarding escape quotes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to pass this option to socket.io which is needed to support IE7-9.
Try fixing IE
…dding-no-colors-to-run-command" This reverts commit 56073fc, reversing changes made to b7d591f. Fixes karma-runner#1894, karma-runner#1895
revert: "Merge pull request karma-runner#1791 from budde377/feature-adding-no-col…
feat(server): add 'listening' event with port number
There is no way to resolve them in this case anyway. Fixes karma-runner#1274.
Before, the exception was thrown in MockSourceMapConsumer's constructor and not in its originalPositionFor() function, which however was the expected thing to happen.
…mber-no-source-map fix(reporter): Disable source maps for URLs without line number
…cted-exception fix(test): Throw the expected exception
chore(dependencies): update bluebird v.3
…lint-2.2.0 eslint@2.2.0 breaks build⚠️
…lint-plugin-react-4.0.0 Update eslint-plugin-react to version 4.0.0 🚀
Add detached mode using the `karma start --detached` command. Add middleware for stopping a server (detached or not). Described the detached option.
Add the `stopper` as a command to the public API allowing for enabling users to programically terminate a running server.
Add a setup-function for setting up the log-level and colors from config.
Change the timing on tests, allowing Node 0.10 to catch-up.
…-server Add possibility to stop a karma server
feat(config): Allow custom context and debug files
…pertest-as-promised-3.0.0 Update supertest-as-promised to version 3.0.0 🚀
…, intelligently merge the list of preprocessors, deduping and trying to preserve the order This could be a breaking change, some users might rely on the old order, or on some preprocessors being run multiple times
Add colors and log-level arguments to run argument. Refactor log-setup functions for server and init. Correct bug in server where log-level was ignored before `parseConfig` Closing karma-runner#1067
Delay the decision on color/no-color reporter to write. This is done by letting the individual adapter decide the color and providing a default color to the base adapter. Closing karma-runner#1067
Fix problems: * Not relying on Reporter.USE_COLORS property * Construct factory with right configuration
When loading a reporter, look for a color-version of this.
Add a test of the karma-mocha-reporter. Testing that it outputs correctly.
…ors-to-run-command Feature fix no colors to run command
feat(config): Add `preprocessorOrder` option to config for when prepr…
Change information on how to use node.js on Windows
docs: Including reference to Windows port of nvm
|
This seems fix the single quote issue! |
|
Nice work 👍, I approve this fix! |
|
Problem successful fixed |
|
Great! Will create PR to the Karma project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the fix for issue karma-runner#1876. Requires a review!