Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Including reference to Windows port of nvm #1933

Merged
merged 1 commit into from
Feb 26, 2016
Merged

docs: Including reference to Windows port of nvm #1933

merged 1 commit into from
Feb 26, 2016

Conversation

aaronpowell
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@aaronpowell
Copy link
Contributor Author

CLA signed!

@googlebot
Copy link

CLAs look good, thanks!

@dignifiedquire
Copy link
Member

Thanks can you change the commit message to follow our guidelines please?

@aaronpowell
Copy link
Contributor Author

ah, didn't realise there was a convention, sorry @dignifiedquire, I'll get that resolved 😄

Change information on how to use node.js on Windows
@aaronpowell aaronpowell changed the title Including reference to Windows port of nvm docs: Including reference to Windows port of nvm Feb 26, 2016
@aaronpowell
Copy link
Contributor Author

I wasn't sure how to set the footer part since it doesn't close any specific bug.

dignifiedquire added a commit that referenced this pull request Feb 26, 2016
docs: Including reference to Windows port of nvm
@dignifiedquire dignifiedquire merged commit 8d5d441 into karma-runner:master Feb 26, 2016
@dignifiedquire
Copy link
Member

Thanks, you can leave out the footer if there is nothing to reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants