Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: eslint max depth warnings" #1365

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

samayer12
Copy link
Collaborator

Reverts #1255

@samayer12 samayer12 requested a review from a team as a code owner October 31, 2024 16:20
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 28.88889% with 32 lines in your changes missing coverage. Please review.

Project coverage is 79.69%. Comparing base (7453d6a) to head (598eace).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/mutate-processor.ts 0.00% 16 Missing ⚠️
src/lib/watch-processor.ts 33.33% 11 Missing and 1 partial ⚠️
src/lib/validate-processor.ts 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1365      +/-   ##
==========================================
- Coverage   79.85%   79.69%   -0.17%     
==========================================
  Files          40       40              
  Lines        1941     1945       +4     
  Branches      400      411      +11     
==========================================
  Hits         1550     1550              
- Misses        361      365       +4     
  Partials       30       30              
Files with missing lines Coverage Δ
src/lib/helpers.ts 97.19% <100.00%> (+0.01%) ⬆️
src/lib/validate-processor.ts 13.15% <0.00%> (-0.36%) ⬇️
src/lib/watch-processor.ts 79.20% <33.33%> (+0.56%) ⬆️
src/lib/mutate-processor.ts 9.09% <0.00%> (-0.50%) ⬇️

@samayer12
Copy link
Collaborator Author

There were two failing E2E tests that we need to handled before #1255 is actually good to go.

@cmwylie19 cmwylie19 merged commit 9dbf9ab into main Oct 31, 2024
45 of 46 checks passed
@cmwylie19 cmwylie19 deleted the revert-1255-resolve-eslint-max-depth branch October 31, 2024 16:31
samayer12 added a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants