fix: eslint max depth warnings

[tamirazrab]

Description

Fixes eslint max-depth warnings in different files.

Left out helper.ts purposely not sure how to remove nesting there.

Related Issue

Fixes #1249

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Other (security config, docs update, etc)

Checklist before merging

• Unit, Journey, E2E Tests, docs, adr added or updated as needed
• Contributor Guide Steps followed

[cmwylie19]

We need to hold off on this PR until our release next week. Thank you for your contribution!

[codecov]

Codecov Report

Attention: Patch coverage is 31.70732% with 28 lines in your changes missing coverage. Please review.

Project coverage is 79.85%. Comparing base (0971bd3) to head (e5bce29).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/lib/watch-processor.ts	35.00%	13 Missing ⚠️
src/lib/mutate-processor.ts	0.00%	12 Missing ⚠️
src/lib/validate-processor.ts	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
+ Coverage   79.69%   79.85%   +0.16%     
==========================================
  Files          40       40              
  Lines        1945     1941       -4     
  Branches      384      409      +25     
==========================================
  Hits         1550     1550              
+ Misses        393      389       -4     
  Partials        2        2              

Files with missing lines	Coverage Δ
src/lib/helpers.ts	97.17% <100.00%> (-0.02%)	⬇️
src/lib/validate-processor.ts	13.51% <0.00%> (+0.35%)	⬆️
src/lib/mutate-processor.ts	9.58% <0.00%> (+0.49%)	⬆️
src/lib/watch-processor.ts	78.64% <35.00%> (-0.57%)	⬇️

[samayer12]

Linter warnings are resolved (aside from helper.ts as noted), thank you! Left a couple comments for questions that the maintainers can consider prior to merging.

[cmwylie19]

can you please run npm run format:fix to try and fix the formatting issues? @tamirazrab

[tamirazrab]

can you please run npm run format:fix to try and fix the formatting issues? @tamirazrab

Yes I did, sorry for delay, most warning aren't related to max-depth other than pepr/src/lib/helpers.ts which I'm not really sure how to proceed refactoring it.

[samayer12]

@tamirazrab, thanks for doing the bulk of the work resolving the max-depth warnings! I'm gonna knock out the last few things and update the branch for us since we've had several changes over the past few weeks.

[samayer12]

There are broader issues with test-coverage in the refactored files that we already know about, accepting the small overall decrease to gain linter resolutions.