Skip to content
This repository has been archived by the owner on Feb 15, 2025. It is now read-only.

chore!: uds bundle refs for upstream flavor and namespace #977

Merged
merged 30 commits into from
Sep 10, 2024

Conversation

justinthelaw
Copy link
Contributor

@justinthelaw justinthelaw commented Sep 3, 2024

OVERVIEW

Related to PR #933

Should be merged in after successfully releasing and publishing artifacts related to LeapfrogAI v0.12.0.

BREAKING CHANGES

See PR #933

  • Refs and Repositories for each component in the latest UDS bundles will not include the -upstream flavor appended to the end of the version number (e.g., 0.12.2-upstream)
  • Release-please will no longer properly nor automatically change bundle manifests to the next release version due to the appended flavor (non-SemVer compliant)
  • Updates the Registry1 weekly to 0.12.2 and adds integration tests too

CHANGES

See PR #933

@justinthelaw justinthelaw added dependencies Pull requests that update a dependency file tech-debt Not a feature, but still necessary blocked 🛑 Something needs to happen before this issues is worked labels Sep 3, 2024
Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for leapfrogai-docs canceled.

Name Link
🔨 Latest commit 529e9f1
🔍 Latest deploy log https://app.netlify.com/sites/leapfrogai-docs/deploys/66e08f9c2b56660008b328af

@justinthelaw justinthelaw linked an issue Sep 3, 2024 that may be closed by this pull request
@justinthelaw justinthelaw changed the title chore: uds bundle refs for upstream flavor and namespace chore!: uds bundle refs for upstream flavor and namespace Sep 3, 2024
@justinthelaw justinthelaw self-assigned this Sep 3, 2024
@justinthelaw
Copy link
Contributor Author

Blocked by #933 and completion of all steps after #934. Merge with main and re-run tests after both are completed.

justinthelaw added a commit that referenced this pull request Sep 4, 2024
## BREAKING CHANGES

- LeapfrogAI `latest` UDS bundles on `main` branch will break when this is merged unless the following is done:
  - add `-upstream` to all components in `latest` bundles
  - change namespace of the referenced repository to `packages/uds/leapfrogai`
- release-please does not currently work with flavors as it is currently configured to follow SemVer standards; manual changing of the `latest` bundles ref must be done moving forward until a fix (custom replacement strategy) is implemented

## CHANGES

- Moves bundles to UDS Common standard directory (`bundles/`)
- Shifts the target GHCR repository sub-directory from `packages/leapfrogai` to `packages/uds/leapfrogai` as part of the[ _Made For UDS_](https://github.com/defenseunicorns/uds-common/blob/main/docs/uds-package-practices.md) standard
- Adds `-upstream` as the default bundle ref and increments the ref manually

## NOTES

After 0.12.0 is released and artifacts are published, PR #977 should be merged in to add the UDS bundle manifest pointers necessary to use the `upstream` flavor and v0.12.0 in general.
@justinthelaw justinthelaw linked an issue Sep 5, 2024 that may be closed by this pull request
@YrrepNoj YrrepNoj marked this pull request as ready for review September 6, 2024 16:37
@YrrepNoj YrrepNoj requested a review from a team as a code owner September 6, 2024 16:37
@justinthelaw
Copy link
Contributor Author

Update and review after the 0.12.0 release goes through GHCR and IronBank.

@justinthelaw
Copy link
Contributor Author

justinthelaw commented Sep 7, 2024

jalling97
jalling97 previously approved these changes Sep 9, 2024
@justinthelaw justinthelaw removed the blocked 🛑 Something needs to happen before this issues is worked label Sep 10, 2024
@justinthelaw justinthelaw merged commit caf4f9c into main Sep 10, 2024
28 checks passed
@justinthelaw justinthelaw deleted the post-0.12.0-release-namespace-version-changes branch September 10, 2024 19:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file tech-debt Not a feature, but still necessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(release): Tag current releases as -upstream flavor chore(release): correct ghcr repository directory
5 participants