Packaging #64
Packaging #64
Conversation
Pull Request Test Coverage Report for Build 2005235636Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
- import the mino crontroller to use the public IP instead of 127.0.0.1 - updates the smart contract to use a specified folder. Also makes it configurable via the CLI - fixes wrong use of the temp folder in the combine share - fixes wrong commands in the README - updates uses of 127.0.0.1 to use the default 0.0.0.0 IP - update the start-dvoting script to use added CLI arguments - adds instructions on how to operate a node and setup the chain -
| - Create .deb package: | ||
|
|
||
| ```sh | ||
| make deb |
There was a problem hiding this comment.
Is it hard for make deb to automatically make the unikernel and do all of the above? If not, it might be worth it.
There was a problem hiding this comment.
Not feasible yet, because there is a 'make menuconfig' step where we have to modify the config. We could dig into that to have a default config, but it might take quite some time for little value right now.
contracts/evoting/unikernel/apps/combine_shares/start-unikernel
Outdated
Show resolved
Hide resolved
| export dela_port="9000" | ||
| export prometheus_addr="127.0.0.1:9100" | ||
| export proxy_addr="127.0.0.1:9080" |
There was a problem hiding this comment.
should we simply move these 3 lines into network.env ?
Adds updates to make the setup run on detached VMs
contracts/evoting/evoting.go
Outdated
| err = exportPubshares(tmp, election.PubsharesUnits, numBallots, numChunks) | ||
| dela.Logger.Info().Msgf("using the following folder: %s", tmp) | ||
|
|
||
| err = exportPubshares(filepath.Join(e.exportFolder, tmp), election.PubsharesUnits, numBallots, numChunks) |
There was a problem hiding this comment.
filepath.Join(e.exportFolder, tmp) is recomputed multiple times.
Consider using a variable.
| // start the overlay on the start command, and make sure resources are cleaned | ||
| // when the CLI daemon is stopping. | ||
| // | ||
| // Documentation Last Review: 07.10.2020 |
contracts/evoting/unikernel/apps/combine_shares/start-unikernel
Outdated
Show resolved
Hide resolved
| - Create .deb package: | ||
|
|
||
| ```sh | ||
| make deb |
There was a problem hiding this comment.
Not feasible yet, because there is a 'make menuconfig' step where we have to modify the config. We could dig into that to have a default config, but it might take quite some time for little value right now.
| [Service] | ||
| User=dvoting | ||
|
|
||
| ExecStartPre=/bin/bash -c "rm -f /var/opt/dedis/dvoting/data/dela/daemon.sock" |
| export dela_bin=".../cli/memcoin" | ||
| export dela_data=".../tmp/dela" | ||
| export dela_bin="../../../../../memcoin" | ||
| export dela_data="/tmp/dela" |
There was a problem hiding this comment.
are you sure about this ?
|
Kudos, SonarCloud Quality Gate passed! |
The new scripts provided allow to install and start the unikernel service and then the voting node.