New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds updates to make the setup run on detached VMs #66

Merged

nkcr merged 2 commits into packaging from updates-multiple-vm-checks

Mar 18, 2022

Contributor

nkcr commented Mar 18, 2022

import the mino crontroller to use the public IP instead of 127.0.0.1
updates the smart contract to use a specified folder. Also makes it configurable via the CLI
fixes wrong use of the temp folder in the combine share
fixes wrong commands in the README
updates uses of 127.0.0.1 to use the default 0.0.0.0 IP
update the start-dvoting script to use added CLI arguments
adds instructions on how to operate a node and setup the chain


          Adds updates to make the setup run on detached VMs

8535b76

- import the mino crontroller to use the public IP instead of 127.0.0.1
- updates the smart contract to use a specified folder. Also makes it configurable via the CLI
- fixes wrong use of the temp folder in the combine share
- fixes wrong commands in the README
- updates uses of 127.0.0.1 to use the default 0.0.0.0 IP
- update the start-dvoting script to use added CLI arguments
- adds instructions on how to operate a node and setup the chain
-

nkcr self-assigned this


          Fixes the tests

5362a2c

sonarqubecloud bot commented Mar 18, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
11 Code Smells

22.1% Coverage
0.0% Duplication

coveralls commented Mar 18, 2022

Pull Request Test Coverage Report for Build 2005214226

20 of 35 (57.14%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 55.021%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
services/dkg/pedersen/controller/mod.go	8	23	34.78%

Totals
Change from base Build 2004449438:	-0.03%
Covered Lines:	3090
Relevant Lines:	5616

💛 - Coveralls

nkcr merged commit a951ef5 into packaging

nkcr deleted the updates-multiple-vm-checks branch

March 18, 2022 16:20

coveralls commented Sep 19, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 2005214226

Details

20 of 35 (57.14%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 55.021%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
services/dkg/pedersen/controller/mod.go	8	23	34.78%

Totals
Change from base Build 2004449438:	-0.03%
Covered Lines:	3090
Relevant Lines:	5616

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet