New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move LLVS to EE #126

Merged

AleksZimin merged 49 commits into main from astef-llvs-ee

Feb 18, 2025

Member

astef commented Feb 13, 2025

Description

Functionality of snapshots should be available only for EE edition of the product. With this change we're:

separating EE/CE logical branches in Go code
adding support of conditional test/lint/build to out CI
letting developer choose the edition with labels
adding validating webhook, which will forbit creating of LLVS
LLVS will be present in all editions

Why do we need it, and what problem does it solve?

This change aligns the existing feature design with Deckhouse policies.

What is the expected result?

EE users will not be affected
CE users will not be able to create LLVS, existing LLVSs won't be reconciled, PVC with LLVS source will lead to controller errors.

Checklist

Changes were tested in the Kubernetes cluster manually.

astef added the enhancement label

astef requested review from duckhawk, AleksZimin and krpsh123

February 13, 2025 10:23

astef self-assigned this

astef mentioned this pull request

Move LLVS to EE #114

Merged

1 task

astef force-pushed the astef-llvs-ee branch from 2ac7b55 to 78f067f Compare

February 13, 2025 12:06

astef and others added 23 commits

February 13, 2025 15:19


          Move LLVS to EE

e3ea932

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          also move snapshots restore to EE

8bfb31b

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          fix linter

22210fe

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          [docs] Add labels list for BlockDevice (#121)

ef104f4

Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>


          [github] CI: add editions

8df78d8

Signed-off-by: Pavel Karpov <pavel.karpov@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          include llvs always

d216988

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          added webhook

589735a

Signed-off-by: Nikolay Demchuk <nikolay.demchuk@flant.com>

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          fixes

a31a695

Signed-off-by: Nikolay Demchuk <nikolay.demchuk@flant.com>

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          change

4fde4d2

Signed-off-by: Nikolay Demchuk <nikolay.demchuk@flant.com>

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          fixes

5fef574

Signed-off-by: Nikolay Demchuk <nikolay.demchuk@flant.com>

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          fixes

ad96530

Signed-off-by: Nikolay Demchuk <nikolay.demchuk@flant.com>

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          changed go version

91f82be

Signed-off-by: Nikolay Demchuk <nikolay.demchuk@flant.com>

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>

fix

7a1c568

Signed-off-by: Nikolay Demchuk <nikolay.demchuk@flant.com>

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>

try

b180e15

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          [webhooks] fix werf

39a5d15

Signed-off-by: Pavel Karpov <pavel.karpov@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          bump go version to 1.23.5

7c7cab8

Signed-off-by: Pavel Karpov <pavel.karpov@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          update go

d0724ff

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          fix yamls

3d5d082

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          fix caBundle

92377bc

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          better message

8c8937a

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          optionally disable validating webhook when featureLLVSEnabled

ca24d46

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          fix overwriting openapi folder in bundle

ba5fad8

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          fix bundle problem; change build trigger

67ca9a1

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>

astef and others added 20 commits

February 13, 2025 15:21


          fix typo

c5e682f

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          fix reversed logic of featureLLVSEnabled

5c692a1

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          upgrade Go in workflows

dec45c6

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          fix linter

9a764f2

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          some changes

1632ff2

Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          another fix

280f6d8

Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          another fixes2

d2c8893

Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          fixes

62fe597

Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          fixes

766f00e

Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          some fixes

9f72440

Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          change workflows

4bb050e

Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          some changes in choice edition

6413fe0

Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          change werf

4724b5f

Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>

fix

9c36325

Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          fix default MODULE_EDITION

c25ac75

Signed-off-by: Pavel Karpov <pavel.karpov@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          leave conditional build only in feature flags

6bef14e

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          revert "leave conditional build only in feature flags"

b202326

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          temp

09261c8

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          remove redundand validation logic

cf9d419

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          fix webhok, remove choice-edition.yaml

769e9fc

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>

astef force-pushed the astef-llvs-ee branch from 78f067f to 769e9fc Compare

February 13, 2025 12:21

astef added 6 commits

February 13, 2025 17:43


          fix merge conflict

14308dc

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          fix edition selection algorithm

8b7ee5f

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          avoid non-zero status

e4b486b

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          avoid non-zero status 2

59b76da

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          minor fixes after self-review

9089dc5

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>


          pass DEFAULT_EDITION from vars

6eaa8e3

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>

AleksZimin approved these changes

View reviewed changes

AleksZimin merged commit 48ca0f5 into main

9 of 11 checks passed

AleksZimin deleted the astef-llvs-ee branch

February 18, 2025 12:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels