Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LLVS to EE #114

Merged
merged 41 commits into from
Feb 12, 2025
Merged

Move LLVS to EE #114

merged 41 commits into from
Feb 12, 2025

Conversation

astef
Copy link
Member

@astef astef commented Dec 19, 2024

Description

Functionality of snapshots should be available only for EE edition of the product. With this change we're:

  • separating EE/CE logical branches in Go code
  • adding support of conditional test/lint/build to out CI
  • letting developer choose the edition with labels
  • adding validating webhook, which will forbit creating of LLVS
  • LLVS will be present in all editions

Why do we need it, and what problem does it solve?

This change aligns the existing feature design with Deckhouse policies.

What is the expected result?

EE users will not be affected
CE users will not be able to create LLVS, existing LLVSs won't be reconciled, PVC with LLVS source will lead to controller errors.

Checklist

  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
@astef astef added the enhancement New feature or request label Dec 20, 2024
@astef astef requested review from duckhawk and AleksZimin December 20, 2024 08:13
@astef astef marked this pull request as ready for review December 20, 2024 08:14
krpsh123 and others added 23 commits February 3, 2025 14:56
Signed-off-by: Pavel Karpov <pavel.karpov@flant.com>
Signed-off-by: Pavel Karpov <pavel.karpov@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Signed-off-by: Nikolay Demchuk <nikolay.demchuk@flant.com>
Signed-off-by: Nikolay Demchuk <nikolay.demchuk@flant.com>
Signed-off-by: Nikolay Demchuk <nikolay.demchuk@flant.com>
Signed-off-by: Nikolay Demchuk <nikolay.demchuk@flant.com>
Signed-off-by: Nikolay Demchuk <nikolay.demchuk@flant.com>
Signed-off-by: Nikolay Demchuk <nikolay.demchuk@flant.com>
Signed-off-by: Nikolay Demchuk <nikolay.demchuk@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Signed-off-by: Pavel Karpov <pavel.karpov@flant.com>
Signed-off-by: Pavel Karpov <pavel.karpov@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
astef added 2 commits February 7, 2025 19:55
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
AleksZimin and others added 13 commits February 9, 2025 22:22
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Pavel Karpov <pavel.karpov@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
@astef astef marked this pull request as draft February 11, 2025 11:55
@astef astef merged commit 50d5077 into main Feb 12, 2025
8 of 11 checks passed
@astef
Copy link
Member Author

astef commented Feb 13, 2025

This merge was a mistake, it was reverted, and the new PR created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants