feat: Validate start is not 0 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## feat/token-vesting-v2 #69 +/- ##
=======================================================
Coverage 100.00% 100.00%
=======================================================
Files 3 3
Lines 137 138 +1
Branches 31 32 +1
=======================================================
+ Hits 137 138 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nachomazzara
approved these changes
Nov 22, 2022
fzavalia
added a commit
that referenced
this pull request
Nov 29, 2022
* chore: Use lockfile v2 (#29) * feat: Add hardhat (#30) * chore: Add hardhat toolbox * chore: Add hardhat * chore: Add hardhat config * feat: contractsOld folder * feat: Add test contract * chore: Add artifacts and cache to gitignore * chore: Use hardhat toolbox in config * chore: Test * chore: EOL * feat: Create PeriodicTokenVesting contract (#32) * chore: Install OZ libs * feat: Delete test files * feat: Add PeriodicTokenVesting contract and tests * feat: Add parameters to initialize function (#33) * chore: Install hardhat network helpers * feat: Add MockToken * feat: Add init variables and getters * feat: Add more initialize tests * feat: Add validations and comments * chore: Add more initialize tests * feat: Set beneficiary (#35) * feat: Add setBeneficiary function * chore: Add tests for setBeneficiary * feat: Add release function (#36) * feat: Add _getVested and release functions * fix: Fix tests * feat: Add getReleased and update release function * feat: Test release function * chore: Enable gas reporter * chore: Ignore coverage * chore: Add comments * feat: Update to elapsedPeriods > vestedPerPeriodLength * chore: Test revert when vesting has not started * feat: Add getReleasable and getVested functions * feat: Change _setBeneficiary accessor * chore: EOL * feat: Revoke function (#37) * feat: Add revoked function * feat: Add revoke tests * chore: Add release test when revoked * chore: Add release test for the currently elapsed periods * feat: Release foreign token function (#38) * feat: Add releaseForeignToken function * chore: Test release foreign token * feat: Add and test ReleasedForeign event * feat: Index the _token param in ReleasedForeign event * feat: Release surplus (#39) * feat: Add releaseSurplus function * chore: Add releaseSurplus tests * feat: Misc (#40) * chore: Test missing events * chore: Update comments * feat: Update events * feat: Release all foreign tokens * feat: Release to beneficiary and release to arbitrary receiver functions * feat: More config for releaseForeignToken * chore: Remove ethers trainwreck * feat: Unique release function with receiver and amount * feat: Add receiver and amount to releaseSurplus * feat: Change error message * chore: Change argument name * chore: Add various comments * feat: Add getTotal function to obtain the total amount of tokens that will be vested by the contract * chore: Update comment * feat: Deploy PeriodicTokenVesting implementation script (#43) * chore: Add hardhat etherscan and dotenv libs * chore: Add env example file * chore: Add .env to ignore files * chore: Update lock file * chore: Update hardhat config * feat: Add deploy periodic token vesting implementation script * feat: Validate period duration and vested per period values * feat: Use SafeERC20 and safeTransfer were transfer is used (#48) * feat: Implement OZ PausableUpgradeable (#50) * feat: Add pause and unpause * feat: Pause and unpause only callable when not revoked * chore: Test pause and unpause events * chore: Define optimizer runs in HH config * feat: Add getIsPaused function * chore: Move getIsPaused func * chore: Add comment to getIsPaused function * feat: Rename to stopTimestamp and set it with pause * chore: Move require up * chore: Add comments to modifiers * chore: Change require > 0 to != 0 * feat: Remove getIsPaused function * feat: Add isPausable variable * fix: Release surplus on pause (#51) * chore: Update comments * fix: Release surplus allow the owner to release non surplus tokens when paused * chore: Update comment * chore: Test releaseSurplus on revoke * chore: Tests * feat: Have an isRevoked variable to simplify logic * chore: Update comments * feat: Linear vesting (#52) * feat: Support linear vesting * chore: Test release foreign token when token is the same as the vested one * chore: Test release surplus when the contract does not have surplus funds * chore: Test release when more than the defined periods have elapsed * chore: Add various getVested functions * chore: Add test for released variable though getReleased * chore: Update comment * chore: Ignore .vscode * chore: Test init and release with many vested per period elements * chore: Compile and Test contracts on github CI * feat: Codecov (#54) * chore: Add codecov action to ci * chore: Update test to coverage in CI * chore: Update job name * chore: Add npm cache to CI * chore: Add coverage badge to readme * chore: Comment tests to view difference in coverage * chore: Uncomment tests * feat: isLinear + cliffDuration (#57) * feat: Add linear struct to determine if tokens are vested between periods * feat: Add set linear function with extra validations * chore: Update tests * chore: Update tests * chore: Update tests * chore: Optimize for loops * chore: Add comment * chore: Add comment * feat: isLinear and cliffDuration * chore: Fix tests * chore: Update comment * chore: Update tests * chore: Update README * fix: Linear vesting calculation when cliff is longer than the period … (#59) * fix: Linear vesting calculation when cliff is longer than the period duration * feat: Remove unnecessary if condition * chore: Update comments * chore: Add more tests to check cliff * chore: Update readme * feat: Rename variables * chore: Remove private setters only used in initialize (#60) * fix: Don't update stop timestamp when revoked after pause (#63) * fix: Don't update stop timestamp when revoked after pause * chore: Update test * feat: Downgrade and lock to 0.8.2 (#65) * feat: Validate start is not 0 (#69) * feat: OwnableBatchVestings (#68) * feat: Add OwnableBatchVestings contract * feat: Lock OwnableBatchVestings version * chore: Add tests for ownable batch vestings * chore: Add dot to README * chore: Remove dot from README * feat: Make owner immutable * chore: Store vested per period in memory before iterating (#70) * chore: Add 256 to uint (#71) * feat: Add script to deploy OwnableBatchVestings * feat: Support deployment of new contract through the UI (#61) * chore: Fix compilation errors * feat: Add react router dom * feat: WIP CreateSingle and CreateBatch v2 components * chore: Reorder imports * feat: Add contracts in goerli for original ui * feat: Deploy new vesting contract in /v2/batch * fix: How data is formed for transaction * chore: Remove unused chains from configs * chore: Update single deploy UI to support new contract * feat: Add batch vesting address field to change the contract * fix: Hook * chore: add margin to batch contract field * fix: Use batch vesting address when sending the transaction * feat: New deployments will be under / and /batch * chore: Add dot to README * feat: Move old components to v1 and rename * feat: Install ethers * feat: Add message regarding old deployer * feat: Add message regarding old deployer * feat: Update implementation address for v2 * feat: Remove empty lines from csv * feat: Add ethereum to v2 ui * feat: Show error * feat: Update vesting impl address for mainnet (#73) * feat: Deploy to Mainnet (#72)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.