feat: Validate start is not 0 (#69)

decentraland · Nov 22, 2022 · b3fa99c · b3fa99c
1 parent 243ee6e
commit b3fa99c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/contracts/PeriodicTokenVesting.sol b/contracts/PeriodicTokenVesting.sol
@@ -108,6 +108,8 @@ contract PeriodicTokenVesting is OwnableUpgradeable, PausableUpgradeable {
             "PeriodicTokenVesting#initialize: INVALID_TOKEN"
         );
 
+        require(_start != 0, "PeriodicTokenVesting#initialize: INVALID_START");
+
         require(
             _period != 0,
             "PeriodicTokenVesting#initialize: INVALID_PERIOD_DURATION"

diff --git a/test/PeriodicTokenVesting.spec.js b/test/PeriodicTokenVesting.spec.js
@@ -171,6 +171,15 @@ describe("PeriodicTokenVesting", () => {
         "PeriodicTokenVesting#initialize: INVALID_VESTED_PER_PERIOD_LENGTH"
       );
     });
+
+    it("reverts when start is 0", async () => {
+      initParams.start = 0;
+      initParamsList = Object.values(initParams);
+
+      await expect(vesting.initialize(...initParamsList)).to.be.revertedWith(
+        "PeriodicTokenVesting#initialize: INVALID_START"
+      );
+    });
   });
 
   describe("getTotal", () => {