Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: night/day 'ex-skybox' button animation #3198

Merged
merged 6 commits into from
Jan 28, 2025
Merged

style: night/day 'ex-skybox' button animation #3198

merged 6 commits into from
Jan 28, 2025

Conversation

RominaMarchetti
Copy link
Contributor

What does this PR change?

This PR introduces the skybox button animation in the sidebar

How to test the changes?

  1. Launch the explorer
  2. Go to the sidebar and find the night/day (skybox) button. Validate the hover/unhover animations work combined with the button name hint.
    Sky_Hover_Unhover

@RominaMarchetti RominaMarchetti requested review from a team as code owners January 23, 2025 19:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

badge

Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit 49f346e
Logs https://github.com/decentraland/unity-explorer/actions/runs/12991635902
Download Windows https://github.com/decentraland/unity-explorer/suites/33567998684/artifacts/2491360387
Download Windows S3 https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/style/skybox-button-animation/Decentraland_windows64.zip
Download Mac https://github.com/decentraland/unity-explorer/suites/33567998684/artifacts/2491344998
Download Mac S3 https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/style/skybox-button-animation/Decentraland_macos.zip
Built on 2025-01-27T15:22:05Z

@RominaMarchetti RominaMarchetti requested review from DafGreco and removed request for dalkia January 23, 2025 19:35
Ludmilafantaniella
Ludmilafantaniella approved these changes Jan 24, 2025
View reviewed changes
Copy link

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Style verified on Windows and Mac. A smoke test was also conducted on other sidebar buttons, as well as the Backpack, Settings, and Gallery, to ensure everything continues to work as expected.

skybox.mp4

@aixaCode aixaCode added the clean-build Used to trigger clean build on PR label Jan 27, 2025
AnsisMalins
AnsisMalins approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@AnsisMalins AnsisMalins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no code changes. Nothing to review.

@m3taphysics m3taphysics enabled auto-merge (squash) January 28, 2025 09:28
@m3taphysics m3taphysics merged commit 595fe1d into dev Jan 28, 2025
7 checks passed
@m3taphysics m3taphysics deleted the style/skybox-button-animation branch January 28, 2025 09:29
@Ludmilafantaniella Ludmilafantaniella mentioned this pull request Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnsisMalins AnsisMalins AnsisMalins approved these changes

@aixaCode aixaCode aixaCode approved these changes

@Ludmilafantaniella Ludmilafantaniella Ludmilafantaniella approved these changes

Assignees

@RominaMarchetti RominaMarchetti

Labels
clean-build Used to trigger clean build on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RominaMarchetti @AnsisMalins @aixaCode @Ludmilafantaniella @m3taphysics @EstefaniaColutta