Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert of #3096 #3163

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: revert of #3096 #3163

merged 1 commit into from
Jan 20, 2025

Conversation

dalkia
Copy link
Collaborator

@dalkia dalkia commented Jan 17, 2025

What does this PR change?

#3096 had to be reverted since version cannot be ignored. If it does, we get error as following

image

Since Unity tries to load a new asset bundle with the same GUID, even if the asset version is different

Therefore, if two assets have different versions, they will be shared.

How to test the changes?

  1. Launch the explorer
  2. Do the happy path

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@dalkia dalkia requested review from a team as code owners January 17, 2025 18:04
@dalkia dalkia enabled auto-merge (squash) January 20, 2025 11:46
Copy link
Contributor

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Happy path reviwed on windows and working as expected:

  • Login flow
  • Make changes on profile and avatar
  • Go around DCL
  • Take pictures
  • Checking the map
  • Multiplayer (chat, visualization, making changes, emotes)

@dalkia dalkia merged commit 76e0edb into dev Jan 20, 2025
10 of 14 checks passed
@dalkia dalkia deleted the fix/rollback-version-adding branch January 20, 2025 11:48
@DafGreco
Copy link

Sanity check performed on Macos 🏁

No issues were found during the sanity check on Macos. All functionalities are working as expected 👍

  • Camera functionality (gallery) ✅
  • Teleport : Dollhouse / the inn / Metadynelabs/ Olavra✅
  • Map✅
  • Badges✅
  • Avatar customization✅
  • Login/logout✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants