-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add version for shared assets bundles #3096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we keep blocking assets-sharing that could be perfectly shared, but maybe given the current scenario this is the best option?
Currently at least these 2 conditions have to be met for the same asset to be shared between different scenes:
- The scenes have to be using the exact same asset file
- The scenes have to be in the exact same “asset bundles conversion version”, given the
assetBundlesBaseUrl.Append(new URLPath($"{version}/{hash}"));
(this is something I think will RARELY happen)
We have to take a decision. If two assets have different version, I think that the safer option is not to share them. If the outdated one is broken, the new one may unintentional broken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Approved by QA. Sanity check performed on Windows and Mac:
- LogIn/Log out using differents accounts
- Backpack
- Social Interactions
- Multiplayer
- Emotes functionality
- Map Functionality
- Camera, Camera Reel
- Profile
- Teleport using GP Carrousel, Coords and Map. Scenes/world visited: Pravus Olavra, Metadynelabs, Doll House, Seed, Casa Roustan
What does this PR change?
LoadSystemBase
should return the correct asset accordinglyHow to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md