fix: block camera reel input in passport #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below. |
anicalbano
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
✔️ Working as intended on Windows
The regression also included:
- Check that the searchabar on Map keeps working
- Check that the search on Backpack keeps working
- Test other sections of My Profile to check that, by pressing C, everything remains normal
- Tested after a picture was taken (the shortcut used)
- Used other keys that can be used for the camera too
13.01.2025_15.24.39_REC.mp4
13.01.2025_15.26.45_REC.mp4
Ludmilafantaniella
approved these changes
Jan 13, 2025
davidejensen
approved these changes
Jan 14, 2025
aixaCode
pushed a commit
that referenced
this pull request
Jan 14, 2025
* fix: block camera reel input in passport (#3110) * Update UI Text Localization Table_en.asset --------- Co-authored-by: lorenzo-ranciaffi <41125365+lorenzo-ranciaffi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Block camera reel inputs (
KandC) while the passport is openHow to test the changes?
KorCno action is triggered and you can normally write textOur Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md