-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sdk pointer event toggle highlight #2651
Conversation
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below. |
I'll update the protocol package to point to the latest published one after the protocol PR is merged. |
🔴 The HIGHLIGHT/GLOW highlight isn't working on both Windows and Mac. 2651.Fail.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Feat verified on Mac and Windows 🎉
Each pointer event cube displayed the correct hover/highlight states as labeled. QA Approved.
2651.approve.mp4
Smoke test was performed covering:
- Social interaction (chat, passports, sync)
- Backpack
- Emoting
- Changing location using chat command and map
- changing wearables
- Minigames
- Hovering over GP buttons and other interactables elements
- Scenes: Doll House, Casa Roustan, Metadynelabs
WHY
Currently scenes have no control over the automatic shader highlighting that happens on interractable objects (pointer event entities).
These are the possible pointer events feedback combinations that the scene can set today:
These other states are not possible today:
WHAT
showHighlight
property in thePBPointerEvents
component, binding the highlight setup of entities to that property.showFeedback
usage to also avoid enabling the highlight if it'sfalse
, as the highlight is also the feedbackhoverText
if the component comes with that property with an empty string. Didn't touch the existent behaviour of not coming with that optional property that ends up using the default "Interact" hover text.Tackles: decentraland/creator-hub#160
Related PRs:
QA TEST INSTRUCTIONS
npm i
and thennpm run start -- --explorer-alpha
/reload
chat command to reload the scene, to avoid THIS OTHER BUG.