Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pointer event toggle highlight #1024

Merged
merged 9 commits into from
Oct 31, 2024

Conversation

pravusjif
Copy link
Member

@pravusjif pravusjif commented Oct 30, 2024

  • Implements support for new PointerEvents showHighlight property
  • Fixed bug existent bug for the case of using pointerEventsSystem.onPointerDown() without any of the pointer event optional properties (those entities weren't clickable before this PR)

Related PRs:

@pravusjif pravusjif self-assigned this Oct 30, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 30, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 630cb31
Status: ✅  Deploy successful!
Preview URL: https://2cf315a0.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-pointer-event-toggle-hi.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Oct 30, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/pointer-event-toggle-highlight/dcl-sdk-7.6.5-11611608113.commit-37b2b53.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/pointer-event-toggle-highlight/dcl-sdk-commands-7.6.5-11611608113.commit-37b2b53.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/pointer-event-toggle-highlight/@dcl/inspector/dcl-inspector-7.6.5-11611608113.commit-37b2b53.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/pointer-event-toggle-highlight-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/pointer-event-toggle-highlight

@pravusjif pravusjif requested a review from gonpombo8 October 30, 2024 18:45
@pravusjif pravusjif marked this pull request as ready for review October 30, 2024 18:45
@pravusjif
Copy link
Member Author

I'll update the protocol package to point to the latest published one after the protocol PR is merged.

package.json Outdated Show resolved Hide resolved
packages/@dcl/ecs/src/systems/events.ts Outdated Show resolved Hide resolved
@pravusjif pravusjif requested a review from gonpombo8 October 31, 2024 12:44
@pravusjif pravusjif merged commit a53af9d into main Oct 31, 2024
8 checks passed
@pravusjif pravusjif deleted the feat/pointer-event-toggle-highlight branch October 31, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants