Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix selection after duplicating (PR #1000 🚀) #1000

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix selection after duplicating (PR #1000 🚀) #1000

merged 1 commit into from
Sep 17, 2024

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Sep 16, 2024 •
edited
Loading

@nicoecheza nicoecheza changed the title fix selection after duplicating fix selection after duplicating (PR #1000 🚀) Sep 16, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 16, 2024 •
edited
Loading

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 02ed0fa
Status: ✅  Deploy successful!
Preview URL: https://49eb87ef.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-duplicate-selection.js-sdk-toolchain.pages.dev

View logs

@nicoecheza nicoecheza force-pushed the fix/duplicate-selection branch from fe05e8c to ab1af2d Compare September 16, 2024 16:58
@nicoecheza nicoecheza force-pushed the fix/duplicate-selection branch from ab1af2d to 02ed0fa Compare September 16, 2024 17:25
@github-actions GitHub Actions
Copy link
Contributor

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/duplicate-selection/dcl-sdk-7.5.8-10888885908.commit-70276fb.tgz"

  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/duplicate-selection/dcl-sdk-commands-7.5.8-10888885908.commit-70276fb.tgz"
npx $SDK_COMMANDS init

  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/duplicate-selection/@dcl/inspector/dcl-inspector-7.5.8-10888885908.commit-70276fb.tgz"

  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/duplicate-selection-e2e

  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/duplicate-selection

@nicoecheza nicoecheza merged commit ddc542d into main Sep 17, 2024
8 checks passed
@nicoecheza nicoecheza deleted the fix/duplicate-selection branch September 17, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyaiox cyaiox cyaiox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After duplicating I'm still on the original
2 participants
@nicoecheza @cyaiox