Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from PrefectHQ:main #16

Open
wants to merge 4,910 commits into
base: main
Choose a base branch
from
Open

[pull] main from PrefectHQ:main #16

wants to merge 4,910 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Feb 1, 2023

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label Feb 1, 2023
</script>
<!-- Segment analytics -->
<script>
!function(){var analytics=window.analytics=window.analytics||[];if(!analytics.initialize)if(analytics.invoked)window.console&&console.error&&console.error("Segment snippet included twice.");else{analytics.invoked=!0;analytics.methods=["trackSubmit","trackClick","trackLink","trackForm","pageview","identify","reset","group","track","ready","alias","debug","page","once","off","on","addSourceMiddleware","addIntegrationMiddleware","setAnonymousId","addDestinationMiddleware"];analytics.factory=function(e){return function(){var t=Array.prototype.slice.call(arguments);t.unshift(e);analytics.push(t);return analytics}};for(var e=0;e<analytics.methods.length;e++){var key=analytics.methods[e];analytics[key]=analytics.factory(key)}analytics.load=function(key,e){var t=document.createElement("script");t.type="text/javascript";t.async=!0;t.src="https://cdn.segment.com/analytics.js/v1/" + key + "/analytics.min.js";var n=document.getElementsByTagName("script")[0];n.parentNode.insertBefore(t,n);analytics._loadOptions=e};analytics._writeKey="xDLAoTXsNYpC4Y6JucKnJ8W1MYBuyAbD";;analytics.SNIPPET_VERSION="4.15.3";

Check notice

Code scanning / CodeQL

Semicolon insertion

Avoid automated semicolon insertion (91% of all statements in [the enclosing function](1) have an explicit semicolon).
flows/agent.py Outdated
subprocess.run(["prefect", "work-queue", "create", "test"])
try:
subprocess.run(["prefect", "agent", "start", "test"], timeout=30)
except subprocess.TimeoutExpired:

Check notice

Code scanning / CodeQL

Empty except

'except' clause does nothing but pass and there is no explanatory comment.
flows/agent.py Outdated
subprocess.run(
["prefect", "agent", "start", "--work-queue", "default"], timeout=30
)
except subprocess.TimeoutExpired:

Check notice

Code scanning / CodeQL

Empty except

'except' clause does nothing but pass and there is no explanatory comment.

@abc.abstractmethod
async def _emit(self, event: Event) -> None: # pragma: no cover
...

Check notice

Code scanning / CodeQL

Statement has no effect

This statement has no effect.

# make sure we have actually connected
pong = await self._websocket.ping()
await pong

Check notice

Code scanning / CodeQL

Statement has no effect

This statement has no effect.
return

pong = await self._websocket.ping()
await pong

Check notice

Code scanning / CodeQL

Statement has no effect

This statement has no effect.
table.add_column("Name", style="green", no_wrap=True)
table.add_column("Deployment ID", style="blue", no_wrap=True)

window = pendulum.now("utc").add(hours=hours or 1)

Check notice

Code scanning / CodeQL

Unused local variable

Variable window is not used.
block_document = await client.read_block_document(self.storage_block_id)
storage_block: ReadableFileSystem = Block._from_block_document(block_document)
content = await storage_block.read_path(self.storage_key)
blob = PersistedResultBlob.parse_raw(content)
return blob

@classmethod
def _infer_path(cls, storage_block, key) -> str:

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
def __post_init__(self):
logger.debug("Created work item %r", self)

def run(self):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.

result = work_item.run()
if inspect.isawaitable(result):
await result

Check notice

Code scanning / CodeQL

Statement has no effect

This statement has no effect.
@pull pull bot added the merge-conflict Resolve conflicts manually label Mar 1, 2023
NobisIndustries and others added 24 commits January 30, 2025 10:37
Co-authored-by: Fabian Nobis <fabian.nobis@deutschebahn.com>
Co-authored-by: daniel-prefect <daniel@prefect.io>
Co-authored-by: Devan Grose <=>
Co-authored-by: Alex Streed <desertaxle@users.noreply.github.com>
Co-authored-by: daniel-prefect <daniel@prefect.io>
Co-authored-by: nate nowack <thrast36@gmail.com>
Co-authored-by: Alex Streed <alex.s@prefect.io>
Co-authored-by: marvin-robot <marvin-robot@users.noreply.github.com>
Co-authored-by: marvin-robot <marvin-robot@users.noreply.github.com>
kevingrismore and others added 30 commits February 26, 2025 10:56
Co-authored-by: Devan Grose <=>
Co-authored-by: Chris Pickett <chris.pickett@prefect.io>
Co-authored-by: Kevin Grismore <146098880+kevingrismore@users.noreply.github.com>
Co-authored-by: marvin-robot <marvin-robot@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: daniel-prefect <daniel@prefect.io>
Co-authored-by: daniel-prefect <daniel@prefect.io>
Co-authored-by: Jenny G <40272060+zhen0@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⤵️ pull merge-conflict Resolve conflicts manually
Projects
None yet
Development

Successfully merging this pull request may close these issues.