Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui-v2] feat: only lint staged changes on pre-commit #17283

Merged
merged 1 commit into from
Feb 26, 2025
Merged

[ui-v2] feat: only lint staged changes on pre-commit #17283

merged 1 commit into from
Feb 26, 2025

Conversation

devangrose
Copy link
Contributor

this reduces wait time on committing by only linting staged files

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 25, 2025
pleek91
pleek91 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

devinvillarosa
devinvillarosa approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@devinvillarosa devinvillarosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🆙

@devangrose devangrose merged commit abef75f into main Feb 26, 2025
13 checks passed
@devangrose devangrose deleted the lint-staged branch February 26, 2025 17:31
devinvillarosa pushed a commit that referenced this pull request Feb 26, 2025
@devangrose @devinvillarosa
[ui-v2] feat: only lint staged changes on pre-commit (#17283)
f14491a 
Co-authored-by: Devan Grose <=>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleek91 pleek91 pleek91 approved these changes

@desertaxle desertaxle desertaxle approved these changes

@devinvillarosa devinvillarosa devinvillarosa approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devangrose @pleek91 @desertaxle @devinvillarosa