-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3.0.0 #29
Merged
Merged
Version 3.0.0 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ddasutein
commented
Feb 20, 2022
•
edited
Loading
edited
- The Date Format system has been overhauled. It now supports format localization. Meaning that the extension can use your country's preferred format. Before, I've written my own framework for this but the problem is that it doesn't work for every country in the world. Not every country uses the western format. Check out the wiki page here on the new settings for it. Lots of different ways to customize it. Replacement of custom date formatting solution #22
- When saving images, you can now add a prefix in the beginning of the file name. To use this, there is another context menu specific for this
- The Options page has received another overhaul. It supports Light and Dark mode (based on your browser settings), animations, blurs, and more
- Announcement banner is now dynamic. This can be controlled on my end here on GitHub and it will only be enabled for announcements that are worth sharing. Don't worry, I won't be abusing this
- You can now set no random string value
- Under System Information, the extension has been updated to detect the difference between Windows 10 and 11 Incorrect Operating System string for Windows 11 #15
- You can see your Browser name or type under System Information. Note, this one is a work in progress. Sometimes it doesn't show the correct browser (e.g., using Edge but it reports as "Chromium"). For Platform, for right now this will only show information for x86 based systems. No support yet to detect ARM and Apple M-series chips. See discussion Requesting additional information for macOS (M1 based), Windows ARM devices, and ChromeOS #23 for details
- Addressing an issue where the extension is throwing persistent "duplicate id" errors. This issue wasn't breaking the extension but was frequently showing up during development since the beginning
- Unification of the options page into a single codebase. Previously each setting page was it's own dedicated page. This is hard to maintain overtime
- Updating the SweetAlert library to support dark mode
- New storage API. Basically means that i've standarized how Settings are loaded to/from local storage. Previously, to load each setting for each website, it must load them by index number. Now, this has been changed to be key-value based. Calling the object's key and corresponding value has proven to simplify a lot of the condition checking needed
+ Moved all context menu ids inside a constant so it's easier to change in the future + Added more comments to detail what each function does
Other localization to be followed
+ Also replaced the preset for date format with the equivalent required by Moment
It would fail to load localization correctly
Restores a previous functionality where if include is checked then all options related to date format is enabled. If unchecked then disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.