Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Operating System string for Windows 11 #15

Closed
ddasutein opened this issue Oct 22, 2021 · 2 comments
Closed

Incorrect Operating System string for Windows 11 #15

ddasutein opened this issue Oct 22, 2021 · 2 comments
Assignees
Labels
In-Review Code review or testing phase

Comments

@ddasutein
Copy link
Owner

Hey everyone!

Windows 11 is available for the general public as of October 5, 2021. There is no compatibility issues given that this a browser extension. So if you are coming from Windows 10, nothing should change. However, there is a known issue with the way the extension queries the Windows version. If you go to About > System Information > Operating System in the extension options, you may notice that even on Windows 11, it still reports as Windows 10. This is because the extension queries this data by checking the user agent provided by the Edge or Google Chrome browser. Unfortunately, Microsoft didn't bother changing the NT version 10.0 to something like 10.1 or 11.0 for Windows 11. As a result, the extension thinks it is still running Windows 10.

Good news is that Microsoft has provided some new APIs that would be able detect if the browser is running on Windows 10 or 11. I will be implementing this in a future release.

https://docs.microsoft.com/en-us/microsoft-edge/web-platform/user-agent-guidance

@ddasutein ddasutein added the Working on it Developer is addressing this issue label Oct 22, 2021
@ddasutein ddasutein self-assigned this Oct 22, 2021
@ddasutein ddasutein pinned this issue Oct 22, 2021
@ddasutein
Copy link
Owner Author

This is running on a Windows 11 system and now the extension is reporting the correct operating system version. Also the browser and it's version will now be included. Though this won't be part of the master branch or upcoming release just yet as i still need to do additional validation. For the mean time, this will part of the fix-os-query branch while this part of the development is ongoing. Once I've validated this new implementation, it will be included in a future release.

image

@ddasutein ddasutein added In-Review Code review or testing phase and removed Working on it Developer is addressing this issue labels Feb 15, 2022
@ddasutein
Copy link
Owner Author

This is already part of the build-release branch and is currently in testing

@ddasutein ddasutein mentioned this issue Feb 25, 2022
@ddasutein ddasutein unpinned this issue Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-Review Code review or testing phase
Projects
None yet
Development

No branches or pull requests

1 participant