Cut metricflow/dbt_semantic_interfaces into repository #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make commands need to list other make commands inline. Additionally we needed to specify the `overwrite-pre-commit` we were calling.
The 80 character line limit is a standard which has it's roots in a time past. Specifically this rule came about from the time of punch cards and then small screens. That's not to say we shouldn't have a line length limit. You could put all of a program in one line, that wouldn't be fun to read / maintain. The length of 120 is gaining traction, but it's kinda a "magic number" in that I'm not sure we have logical proof of why 120 should be the number, but it seems reasonable.
8b400bf to
440f220
Compare
440f220 to
ba2c37c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1
Description
This is the official cut of metricflow/dbt_semantic_interfaces into dbt-semantic-interfaces. Thus, dbt-semantic-interfaces is truly official born.
Checklist
changie newto create a changelog entryNote: Not including changie, changie will be included on future PRs.