Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2346] Cut over current semantic objects and helpers from MetricFlow #1

Closed
Tracked by #7
QMalcolm opened this issue Apr 4, 2023 · 2 comments · Fixed by #31
Closed
Tracked by #7

[CT-2346] Cut over current semantic objects and helpers from MetricFlow #1

QMalcolm opened this issue Apr 4, 2023 · 2 comments · Fixed by #31
Assignees

Comments

@QMalcolm
Copy link
Collaborator

QMalcolm commented Apr 4, 2023

This repository / package is intended to be where the semantic interface protocols live such that MetricFlow and dbt-core (and other projects) have shared importable understood protocol. That's a tall order. It all starts though with the current definitions as they are in MetricFlow, specifically everything that lives in the model director. The only carve outs from that are files & directories for data warehouse validations and dbt-metrics -> MetricFlow conversion. Data warehouse validations will remain part of MetricFlow, and conversions from dbt-metrics to MetricFlow will no longer be needed.

@QMalcolm QMalcolm self-assigned this Apr 4, 2023
@QMalcolm QMalcolm changed the title Cut over current semantic objects and helpers from MetricFlow CT-2355: Cut over current semantic objects and helpers from MetricFlow Apr 4, 2023
@QMalcolm
Copy link
Collaborator Author

QMalcolm commented Apr 4, 2023

This should also include the tests associated with these classes/functions

@QMalcolm
Copy link
Collaborator Author

QMalcolm commented Apr 25, 2023

Since originally creating this issue, we've moved in the direction of first separating out in MetricFlow what should be in dbt-semantic-interfaces. In that regard, the relevant code is currently being moved into metricflow/dbt_semantic_interfaces. Once validations, time, and tests have been moved into that sub directory, and once nothing in that sub directory refers to metricflow, then we can safely cut that directory to this repository.

@QMalcolm QMalcolm changed the title CT-2355: Cut over current semantic objects and helpers from MetricFlow [CT-2355] Cut over current semantic objects and helpers from MetricFlow Apr 26, 2023
@QMalcolm QMalcolm changed the title [CT-2355] Cut over current semantic objects and helpers from MetricFlow [CT-2346] Cut over current semantic objects and helpers from MetricFlow Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant