Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#4252] Serialization error when missing quotes in metrics model ref() call #4287

Merged
merged 1 commit into from
Nov 17, 2021
Merged

[#4252] Serialization error when missing quotes in metrics model ref() call #4287

merged 1 commit into from
Nov 17, 2021

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Nov 16, 2021

resolves #4252

Description

Add validation of metrics model ref call to ensure it contains a string.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Nov 16, 2021
@gshank gshank force-pushed the metric_serialization_error branch from 9b0270c to c97e6e8 Compare November 16, 2021 20:14
@gshank gshank requested review from jtcohen6 and emmyoop November 16, 2021 20:31
emmyoop
emmyoop approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@gshank gshank merged commit bd950f6 into main Nov 17, 2021
@gshank gshank deleted the metric_serialization_error branch November 17, 2021 22:14
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
@gshank @iknox-fa
[#4252] Serialization error when missing quotes in metrics model ref(…
9eac415 
…) call (#4287)

automatic commit by git-black, original commits:
  bd950f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

@emmyoop emmyoop emmyoop approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in serializing with wrong syntax for metric 'model' field
3 participants
@gshank @emmyoop @jtcohen6