Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in serializing with wrong syntax for metric 'model' field #4252

Closed
gshank opened this issue Nov 9, 2021 · 0 comments · Fixed by #4287
Closed

Error in serializing with wrong syntax for metric 'model' field #4252

gshank opened this issue Nov 9, 2021 · 0 comments · Fixed by #4287
Assignees
@gshank

Comments

@gshank
Copy link
Contributor

gshank commented Nov 9, 2021

The correct syntax for the 'model' attribute in a metrics definition is "ref('my_model')". If all of the quotes are removed, we get an error in serializing: E TypeError: can not serialize 'Undefined' object
@gshank gshank self-assigned this Nov 16, 2021
gshank added a commit that referenced this issue Nov 16, 2021
@gshank
[#4252] Serialization error when missing quotes in metrics model ref()
9b0270c 
call
@gshank gshank mentioned this issue Nov 16, 2021
Merged
4 tasks
gshank added a commit that referenced this issue Nov 16, 2021
@gshank
[#4252] Serialization error when missing quotes in metrics model ref()
c97e6e8 
call
gshank added a commit that referenced this issue Nov 17, 2021
@gshank
[#4252] Serialization error when missing quotes in metrics model ref(…
bd950f6 
…) call (#4287)
iknox-fa pushed a commit that referenced this issue Feb 8, 2022
@gshank @iknox-fa
[#4252] Serialization error when missing quotes in metrics model ref(…
9eac415 
…) call (#4287)

automatic commit by git-black, original commits:
  bd950f6
@dbeatty10 dbeatty10 mentioned this issue Jun 8, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gshank gshank

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#4252] Serialization error when missing quotes in metrics model ref() call dbt-labs/dbt-core
2 participants
@gshank @jtcohen6