Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcfm 10.2.2 #288

Closed
wants to merge 2 commits into from
Closed

mcfm 10.2.2 #288

wants to merge 2 commits into from

Conversation

davidchall
Copy link
Owner

action-homebrew-bump-formula


Created with brew bump-formula-pr.

@andriish
Copy link
Contributor

andriish commented Nov 8, 2022

Hi @davidchall ,

in addition to the binaries it is nice to install the headers, i.e. patch the CMakeLists.txt with this line:

install(DIRECTORY "${CMAKE_SOURCE_DIR}/src/Inc/MCFM" DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})

As those headers are needed by sherpa.

Best regards,

Andrii

@davidchall
Copy link
Owner Author

davidchall commented Dec 2, 2022

Error encountered during installation of bundled LHAPDF library:

A linker snapshot was created at:
[1034](https://github.com/davidchall/homebrew-hep/actions/runs/3406828591/jobs/5665864289#step:8:1036)
  	/tmp/libLHAPDF.dylib-2022-11-07-012102.ld-snapshot
[1035](https://github.com/davidchall/homebrew-hep/actions/runs/3406828591/jobs/5665864289#step:8:1037)
  ld: Assertion failed: (_file->_atomsArrayCount == computedAtomCount && "more atoms allocated than expected"), function parse, file macho_relocatable_file.cpp, line 2061.

This error was previously encountered in #285, and is related to a bug in Xcode 14. It looks like GitHub's macos-12 runner image recently upgraded to Xcode 14: actions/runner-images#6225.

@davidchall davidchall added the pr-pull Trigger bot to add bottle to formula and merge PR label Dec 3, 2022
@davidchall
Copy link
Owner Author

in addition to the binaries it is nice to install the headers, i.e. patch the CMakeLists.txt with this line:

install(DIRECTORY "${CMAKE_SOURCE_DIR}/src/Inc/MCFM" DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})

As those headers are needed by sherpa.

Hi @andriish, I decided not to do it in this PR to keep it dedicated to the version bump. If we want to make MCFM compatible with Sherpa, I think this should have a dedicated PR so we can test it works correctly.

P.S. The Sherpa manual describes a script that edits the MCFM source code before installing, so I don't think we can just link Sherpa to the regular MCFM in Homebrew. Instead, we'd need the Sherpa formula to have a dedicated MCFM resource. This is also how the Rivet formula handles its fjcontrib dependency.

@davidchall
Copy link
Owner Author

The change to the GitHub Actions needs to be done separately. Closing this PR and will reopen.

@davidchall davidchall closed this Dec 3, 2022
@davidchall davidchall deleted the bump-mcfm-10.2.2 branch December 3, 2022 17:57
@davidchall davidchall mentioned this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-pull Trigger bot to add bottle to formula and merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants