Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Users to Disable the Auto-Adding Markers to the Active Collection #164

Closed
david-cattermole opened this issue Oct 22, 2020 · 5 comments
Assignees
Labels
enhancement maya tool A user tool inside Maya.
Milestone

Comments

@david-cattermole
Copy link
Owner

Problem / Feature

Users want to be able to disable (or enable) the feature from #138, so that newly created Markers are not added to the active Collection.

The ability to enable/disable automatically adding Markers to Collections is not a feature of Collections, or the Solver UI.
Instead the feature is determined at the basis of mmSolver.

This calls for a kind of "Preference option" that the user may want to change.
Other preferences may also exist in mmSolver and these should be documented and be settable as well.

Software Versions

  • mmSolver version: v0.3.8
  • Maya version: All
  • Operating System (OS): All
@david-cattermole david-cattermole added enhancement maya tool A user tool inside Maya. labels Oct 22, 2020
@david-cattermole david-cattermole added this to the v0.4.0 milestone Oct 22, 2020
@david-cattermole david-cattermole self-assigned this Oct 22, 2020
@RodeoPerchaude
Copy link

First ever post on github for me!
(I am Etienne from RodeoFx)
I will try to get involved with mmsolver git board, thanks for considering my suggestions and keep on the awesome work.

Hello David, thanks for looking into that, adding markers to active collection would be a great option to add to the load marker tool instead of making #138 the default behavior.

@david-cattermole david-cattermole modified the milestones: v0.4.0, v0.3.9 Oct 22, 2020
@david-cattermole
Copy link
Owner Author

Hello Etienne,

That's not a bad idea. I could add another drop-down box to the Load Markers UI which automatically adds the marker to the specified Collection.
By default the drop-down menu would use the active Collection.

I think it's still a good idea to have a preference that users can set, but this Loader Markers UI would override that option and place the marker into the specific Collection that was requested by the user.

What do you think?

David

@david-cattermole
Copy link
Owner Author

Hello @RodeoPerchaude,

I have added a User Preferences window, and an underlying user preferences library to control the behaviour of "Add New Markers To".

You can find the tool in the mmSolver > General Tools > User Preferences... shelf button.
image

The window is currently quite empty except for the one preference:
image

This update will also temporarly disable "Add New Markers To" from running when using the Load Markers tool, even if the user preference has turned the option on. Users must manually apply the Markers to the collection of their choosing, until I can add a feature to the Load Markers UI to automate this.

This will be released in v0.3.9, hopefully this weekend.

David

@RodeoPerchaude
Copy link

Thanks a lot @david-cattermole .

I will definitely use this feature.

david-cattermole added a commit that referenced this issue Nov 2, 2020
We use maya.cmds.executeDeferred() to revert the config option
after the callback has been run.
maya.cmds.executeDeferred() is expected to work because it puts
the command on the list of idle functions to be run, and
ASSUME THE LIST IS ORDERED.
@david-cattermole
Copy link
Owner Author

This will be released shortly in v0.3.9.

Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement maya tool A user tool inside Maya.
Projects
None yet
Development

No branches or pull requests

2 participants