Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya Tool - Solver UI - Auto-add Marker to active Collection #138

Closed
david-cattermole opened this issue Feb 15, 2020 · 1 comment
Closed
Assignees
Labels
maya tool A user tool inside Maya.
Milestone

Comments

@david-cattermole
Copy link
Owner

Feature

As a user works, they may add new Markers on-the-fly, while the Solver UI is open.
It can be annoying to add Markers to the Solver UI after you've added them into the scene.
We expect the user is most likely has the Collection they wish to solve with active in the Solver UI, when a Marker is added to a camera, therefore it makes sense to automatically add this to the Solver UI.

This should only happen when, 1) The Solver UI is opened, and 2) A valid Collection is active.

The user should be able to turn this feature off, but the feature should be turned on by default.

Expected behavior:
When a Marker is created in any way in Maya, the Marker will automatically be added to the Solver UI.

Steps to Reproduce

Example use-case:

  1. Open Solver UI
  2. Create a Collection (or ensure a Collection is active)
  3. Create a Marker using the "Create Marker" shelf button.
    A marker is automatically added to the Collection in step 2.

Another use-case:

  1. Open Solver UI
  2. Create a Collection (or ensure a Collection is active)
  3. Use the "Load Markers" tool
    The loaded markers are automatically added to the Collection in step 2.

Ideally, this feature sure work for all created Markers, and not need to be added explicitly to each tool.

Software Versions

  • mmSolver version: All future versions of mmSolver.
  • Maya version: All supported Maya versions.
  • Operating System (OS): All supported OSs
@david-cattermole david-cattermole added help wanted maya tool A user tool inside Maya. labels Feb 15, 2020
@david-cattermole david-cattermole added this to the v0.4.0 milestone Feb 15, 2020
@david-cattermole david-cattermole self-assigned this Sep 12, 2020
@david-cattermole david-cattermole modified the milestones: v0.4.0, v0.3.7 Sep 12, 2020
david-cattermole added a commit that referenced this issue Sep 14, 2020
This module is designed to be deferred by default and can be used
to trigger multiple times, but the function only run once.
The reason for this is performance - it is often faster to operate
on a batch of nodes/objects/values at once, than calling a
function 1000 times.
david-cattermole added a commit that referenced this issue Sep 14, 2020
In this commit the event function has not yet been defined.
david-cattermole added a commit that referenced this issue Sep 14, 2020
Add event functions to be run when events are triggered.
The registered event functions are added at mmSolver start up to
ensure that users do not need to run any specific code in order
to start the (automatic) events working.
@david-cattermole
Copy link
Owner Author

This feature has been implemented, and is merged onto the "develop" branch ready for the next release.

When a Marker is created via the mmSolver API, an event will trigger and connect the Marker to the "active" Collection node.
When the Collection node's Marker List is updated, the Solver UI will be updated to show the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maya tool A user tool inside Maya.
Projects
None yet
Development

No branches or pull requests

1 participant