Create a DataGemma UI #4913
Merged
Create a DataGemma UI #4913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnoble
reviewed
Jan 30, 2025
static/css/datagemma.scss
Outdated
| * limitations under the License. | ||
| */ | ||
|
|
||
| @import "base"; |
There was a problem hiding this comment.
For new frontend code, can you look into using "emotion" instead of scss? Examples in the new homepage: https://github.com/datacommonsorg/website/blob/master/static/js/apps/homepage/components/home_hero.tsx#L48
| @@ -40,3 +40,4 @@ typing-extensions==4.10.0 | |||
| webdriver-manager==4.0.0 | |||
| Werkzeug==3.0.6 | |||
| wheel==0.38.1 | |||
| git+https://github.com/datacommonsorg/llm-tools.git | |||
There was a problem hiding this comment.
We should publish this to pypi down the road to avoid having to do the git dependency install
server/__init__.py
Outdated
| @@ -45,6 +45,26 @@ | |||
| DEFAULT_NL_ROOT = "http://127.0.0.1:6060" | |||
|
|
|||
|
|
|||
| # Helper method to get an api key first from the environment, then from GCP secrets. | |||
There was a problem hiding this comment.
Nit: use docstrings for comments like go/pystyle#function-docs
dwnoble
approved these changes
Feb 5, 2025
|
thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a basic UI version of the DataGemma notebooks (rag, rig), so that it's easier to play with the two approaches. This is only for internal use and will only be enabled in the local environment and autopush.