-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check canonical denom #10
Open
toshihiko-okubo
wants to merge
1
commit into
main
Choose a base branch
from
check-canonical-denom
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| name: Tests | ||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-go@v4 | ||
| with: | ||
| go-version-file: 'go.mod' | ||
| go-version: '1.20' | ||
| - name: test | ||
| run: | | ||
| go test -v ./... |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| package util | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "strings" | ||
|
|
||
| "github.com/ethereum/go-ethereum/common" | ||
| ) | ||
|
|
||
| // ref https://github.com/hyperledger-labs/yui-ibc-solidity/blob/v0.3.21/contracts/apps/20-transfer/ICS20Lib.sol#L210 | ||
| func ToCanonicalICS20Denom(denom string) (string, error) { | ||
| if common.IsHexAddress(denom) { | ||
| return strings.ToLower(denom), nil | ||
| } | ||
|
|
||
| if strings.Contains(denom, "/") { | ||
| identifiers := strings.Split(denom, "/") | ||
| // If a prefix exists, at least one port-id and one channel-id must be specified | ||
| // ex) ${PortID}/${ChannelID}/${Denom} | ||
| if len(identifiers) < 3 { | ||
| return "", fmt.Errorf("invalid denom format: %s", denom) | ||
| } | ||
|
|
||
| return strings.Join( | ||
| append(identifiers[0:len(identifiers)-1], strings.ToLower(identifiers[len(identifiers)-1])), | ||
| "/"), nil | ||
| } | ||
|
|
||
| return "", fmt.Errorf("invalid denom format: %s", denom) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| package util | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestToLowerICS20Denom(t *testing.T) { | ||
| cases := []struct { | ||
| name string | ||
| in string | ||
| want string | ||
| expectedErr bool | ||
| }{ | ||
| { | ||
| name: "HexAddress", | ||
| in: "0x4639F884305273E856dBa51AF60c10a5b5E0F482", | ||
| want: "0x4639f884305273e856dba51af60c10a5b5e0f482", | ||
| expectedErr: false, | ||
| }, | ||
| { | ||
| name: "WithPrefix", | ||
| in: "Port/channel-0/0x4639F884305273E856dBa51AF60c10a5b5E0F482", | ||
| want: "Port/channel-0/0x4639f884305273e856dba51af60c10a5b5e0f482", | ||
| expectedErr: false, | ||
| }, | ||
| { | ||
| name: "WithMultiplePrefix", | ||
| in: "Port-0/channel-0/Port-1/channel-1/0x4639F884305273E856dBa51AF60c10a5b5E0F482", | ||
| want: "Port-0/channel-0/Port-1/channel-1/0x4639f884305273e856dba51af60c10a5b5e0f482", | ||
| expectedErr: false, | ||
| }, | ||
| { | ||
| name: "Invalid Address Format", | ||
| in: "invalid address format", | ||
| expectedErr: true, | ||
| }, | ||
| { | ||
| name: "Invalid Prefix Format", | ||
| in: "Portchannel-0/0x4639F884305273E856dBa51AF60c10a5b5E0F482", | ||
| expectedErr: true, | ||
| }, | ||
| } | ||
|
|
||
| for _, c := range cases { | ||
| t.Run(c.name, func(t *testing.T) { | ||
| ret, err := ToCanonicalICS20Denom(c.in) | ||
| if c.expectedErr { | ||
| assert.Error(t, err) | ||
| } else { | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, c.want, ret) | ||
| } | ||
| }) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toshihiko-okubo You need to check if the last element is in hex format.
Plus, I think that
IsHexAddressis not enough.ibc-solidity uses
0xas prefix, butIsHexAddressalso accepts0X.