check canonical denom #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toshihiko Okubo <toshihiko.okubo@datachain.jp>
5223003 to
51c3295
Compare
dongrie
approved these changes
Dec 6, 2023
siburu
reviewed
Dec 11, 2023
| } | ||
|
|
||
| return strings.Join( | ||
| append(identifiers[0:len(identifiers)-1], strings.ToLower(identifiers[len(identifiers)-1])), |
There was a problem hiding this comment.
@toshihiko-okubo You need to check if the last element is in hex format.
Plus, I think that IsHexAddress is not enough.
ibc-solidity uses 0x as prefix, but IsHexAddress also accepts 0X.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no mention of LowerCase for PortId in the ibc spec, and since UpperCase was allowed in ibc-go, only the contract address is converted to LowerCase when the prefix is present.