Revert workaround for #2887 #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ 113/113 passed, 5 skipped, 3h36m36s total Running from acceptance #6640 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PR #2895 introduced a workaround for #2887, although the issue was not reproduced.
Careful analysis shows that this workaround is not necessary.
Tests were added recently in
test_context.py.Running the above tests against v0.39 reproduces the issue:
However, running the above tests against v0.40 and above does not reproduce the issue:
The issue was already fixed in
pyspark.pyby PR #2841 and it is likely that the bug reporter was running v0.39This PR:
AttributeError: 'UsedTable' has no attribute 'table'by adding more type checks #2895Linked issues
#2887
Functionality
None
Tests