Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tox Support] Additional Changes for tox default environment name for type checking and flake8 configuration #321

Merged
merged 33 commits into from
Apr 28, 2023
Merged

[Tox Support] Additional Changes for tox default environment name for type checking and flake8 configuration #321

Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
b6ad62c
update gitignore for pyenv files
Apr 19, 2023
56c18a2
ignore tox files
Apr 19, 2023
e0f42e6
hardcode version instead of pulling from gh
Apr 19, 2023
c254c24
move coverage requirement to tox config
Apr 19, 2023
c41d140
remove version py file since it's hardcoded in setup
Apr 19, 2023
15b7d1f
initial working tox commit
Apr 19, 2023
a3b0101
update required coverage versions to be more flexible
Apr 24, 2023
4e899f5
switch order formatters run
Apr 24, 2023
dee6106
ignore env specific coverage files
Apr 24, 2023
7e977ed
update tox config to use coverage run instead of base python to execu…
Apr 24, 2023
5955700
add coverage report env to tox config
Apr 24, 2023
66f488e
update coverage-report description
Apr 24, 2023
10d4394
update a env name for type checking
Apr 24, 2023
c7b2e0c
remove black and flake8 from requirments package and into tox envs
Apr 24, 2023
59bc245
update contributing md file with tox instructions
Apr 24, 2023
bbc0406
add pyenv and tox instructions to CONTRIBUTING md
Apr 24, 2023
7aa9817
Merge branch 'master' into tox-support
Apr 24, 2023
1ab4bd0
Update test.yml
R7L208 Apr 24, 2023
92d4836
adding comment to force testing on GH actions
Apr 24, 2023
0d658e9
removing comment to force testing on GH actions
Apr 24, 2023
fae1671
Update test.yml to fix error caused by typo
R7L208 Apr 24, 2023
571746b
Revert "remove version py file since it's hardcoded in setup"
Apr 25, 2023
2a0b2fb
Revert "hardcode version instead of pulling from gh"
Apr 25, 2023
6004da3
add semver as a dep for testenv in tox ini
Apr 25, 2023
a4d6629
Merge remote-tracking branch 'origin/tox-support' into tox-support
Apr 25, 2023
6093075
add pyproject toml to install semver as build requirement
Apr 25, 2023
b4a170a
update type default env to type-check
Apr 27, 2023
6599a32
fix merge conflict
Apr 27, 2023
1d30f56
move all flake8 configs to tox.ini file
Apr 27, 2023
681c97c
remove toxinidir from flake8 command
Apr 27, 2023
108c3f1
remove all flake8 config from tox ini file and back into flake8 confi…
Apr 27, 2023
5e714a9
remove ignore for F403 for flake8 config and violations
Apr 28, 2023
8279a5f
add noqa for utils import
Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions python/.flake8
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[flake8]
max-line-length = 88
builtins = dbutils
extend-ignore =
extend-ignore =
# Line too long (88 characters) (E501)
E501,
# Name may be undefined, or defined from star imports: module (F405)
Expand All @@ -11,8 +11,18 @@ extend-ignore =
# 'from module import *' used; unable to detect undefined names (F403)
F403
exclude =
.git
__pycache__
env
.env
.tox
build
.venv
venv
.venv
.coverage.py
.coverage
.coveragerc
.eggs
.mypy_cache
.pytest_cache
dbl_tempo.egg-info
.tox
23 changes: 1 addition & 22 deletions python/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ isolated_build = true
envlist =
format
lint
type
type-check
build-dist
; Mirror Supported LTS DBR versions here: https://docs.databricks.com/release-notes/runtime/
; Use correct PySpark version based on Python version present in env name
Expand Down Expand Up @@ -85,24 +85,3 @@ commands =
[coverage:run]
source = tempo
parallel = true

[flake8]
exclude =
.git
__pycache__
env
.tox
build
.venv
venv
.coverage.py
.coverage
.coveragerc
.eggs
.mypy_cache
.pytest_cache
dbl_tempo.egg-info
max-line-length = 88
extend-ignore =
; See https://github.com/PyCQA/pycodestyle/issues/373
E203