-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tox Support] Additional Changes for tox
default environment name for type checking and flake8 configuration
#321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
=======================================
Coverage 85.65% 85.65%
=======================================
Files 6 6
Lines 767 767
Branches 159 159
=======================================
Hits 657 657
Misses 92 92
Partials 18 18 |
flake8 was returning different results locally in virtual env and using tox. This is because the configuration in tox.ini takes precedence over the .flake8 config file. In addition, flake8 no longer supports a global config file after version 4
tox
default environment name for type checking and flake8 configuration
…g so that GH actions aren't broken
tnixon
reviewed
Apr 28, 2023
tnixon
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default Environment Change
type
environment totype-check
which matches the actual environment configurationtype-check
this is needed because
tox list
is showing thetype
default environment which does not exist andtype-check
as an additional environment.flake8 Config Change
.flake8
andtox.ini
. The configurations intox.ini
were incomplete and took precedence when runningflake8
natively and the linting environmenttox -e lint
.[flake8]
config section fromtox.ini
and migrating all config rules to.flake8
forcestox
to look in.flake8
for config rules and does not break the current GH actions