Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tox Support] Additional Changes for tox default environment name for type checking and flake8 configuration #321

Merged
merged 33 commits into from
Apr 28, 2023

Conversation

R7L208
Copy link
Contributor

@R7L208 R7L208 commented Apr 27, 2023

Default Environment Change

  • updating the type environment to type-check which matches the actual environment configuration
  • the default environment list wasn't updated when renaming the env to type-check

this is needed because tox list is showing the type default environment which does not exist and type-check as an additional environment.

flake8 Config Change

  • flake8 config was defined in .flake8 and tox.ini. The configurations in tox.ini were incomplete and took precedence when running flake8 natively and the linting environment tox -e lint.
  • removing the [flake8] config section from tox.ini and migrating all config rules to .flake8 forces tox to look in .flake8 for config rules and does not break the current GH actions

Lorin Dawson and others added 27 commits April 19, 2023 15:32
importing semver in setup caused an error bc it was being imported before requirements file could install it
this matches the actual env name since type was renamed to type-check
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #321 (8279a5f) into master (44f2235) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #321   +/-   ##
=======================================
  Coverage   85.65%   85.65%           
=======================================
  Files           6        6           
  Lines         767      767           
  Branches      159      159           
=======================================
  Hits          657      657           
  Misses         92       92           
  Partials       18       18           

@R7L208 R7L208 requested a review from tnixon April 27, 2023 15:52
flake8 was returning different results locally in virtual env and using tox. This is because the configuration in tox.ini takes precedence over the .flake8 config file. In addition, flake8 no longer supports a global config file after version 4
@R7L208 R7L208 changed the title [Tox Support] Fix a Tox default environment name [Tox Support] Additional Changes for tox default environment name for type checking and flake8 configuration Apr 27, 2023
@R7L208 R7L208 requested a review from tnixon April 28, 2023 17:35
Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnixon tnixon merged commit 74a3cbf into master Apr 28, 2023
@tnixon tnixon deleted the tox-support branch April 28, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants