Revert "Revert "Create a method to generate OAuth tokens (#644)" (#653)" #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR breaks backwards compatibility for databrickslabs/ucx downstream. See build logs for more details. Running from downstreams #147 |
hectorcast-db
commented
May 24, 2024
| @@ -124,11 +176,14 @@ def inner() -> Dict[str, str]: | |||
| token = token_source.token() | |||
| return {'Authorization': f'{token.token_type} {token.access_token}'} | |||
|
|
|||
| return inner | |||
| def token() -> Token: | |||
There was a problem hiding this comment.
The difference from the original is this function. Previous code:
return OAuthCredentialsProvider(inner, inner.token)
That does not work because config.py tries to make a copy of inner which uses a "lock" (and cannot be copied). The function works as a wrapper, and allows this object to be copied without copying inner.
tanmay-db
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9c5fae7.
Changes
Introduce again the method to generate OAuth tokens, including fixes for impacted auth types
Tests
make testrun locallymake fmtapplied