Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Create a method to generate OAuth tokens (#644)" #653

Merged
merged 1 commit into from
May 23, 2024
Merged

Revert "Create a method to generate OAuth tokens (#644)" #653

merged 1 commit into from
May 23, 2024

Conversation

hectorcast-db
Copy link
Contributor

@hectorcast-db hectorcast-db commented May 22, 2024 •
edited
Loading

Changes

This reverts commit db1f4ae.

Azure CredentialsProvider is impacted by the change:
https://github.com/databricks-eng/eng-dev-ecosystem/actions/runs/9187156296/job/25264245409

Reverting to unblock the release

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.83673% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 57.66%. Comparing base (db1f4ae) to head (4f2cd55).

Files Patch % Lines
databricks/sdk/credentials_provider.py 89.74% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
- Coverage   57.67%   57.66%   -0.02%     
==========================================
  Files          48       48              
  Lines       32742    32680      -62     
==========================================
- Hits        18885    18844      -41     
+ Misses      13857    13836      -21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hectorcast-db hectorcast-db changed the title Test Revert "Create a method to generate OAuth tokens (#644)" May 22, 2024
@hectorcast-db hectorcast-db requested a review from tanmay-db May 22, 2024 08:39
@hectorcast-db hectorcast-db added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 9c5fae7 May 23, 2024
9 checks passed
@hectorcast-db hectorcast-db deleted the revert-test branch May 23, 2024 07:07
hectorcast-db added a commit that referenced this pull request May 24, 2024
@hectorcast-db
Revert "Revert "Create a method to generate OAuth tokens (#644)" (#653)"
34ac529 
This reverts commit 9c5fae7.
github-merge-queue bot pushed a commit that referenced this pull request May 24, 2024
@hectorcast-db
Revert "Revert "Create a method to generate OAuth tokens (#644)" (#653)…
2bafb95 
…" (#655)

This reverts commit 9c5fae7.

## Changes
Introduce again the method to generate OAuth tokens, including fixes for
impacted auth types

## Tests

- [x] `make test` run locally
- [x] `make fmt` applied
- [x] relevant integration tests applied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmay-db tanmay-db tanmay-db approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hectorcast-db @codecov-commenter @tanmay-db