Make u2m authentication work with new CLI #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1ae70e to
f512c4a
Compare
nfx
approved these changes
Jun 7, 2023
Merged
nfx
added a commit
that referenced
this pull request
Jun 9, 2023
# Version changelog ## 0.1.9 * Added new services from OpenAPI spec ([#145](#145), [#159](#159)). * Added consistent usage of the `upload(path, IO)` and `download(path) -> IO` across file-related operations ([#148](#148)). * Added Databricks Metadata Service credential provider ([#139](#139), [#130](#130)). * Added exposing runtime credential provider without changing user namespace ([#140](#140)). * Added a check for `is not None` for primitive fields in `as_dict()` ([#147](#147)). * Fixed bug related to boolean flags and convert `True` to `true` in query strings ([#156](#156)). * Fixed generation of external entities ([#146](#146)). * Make u2m authentication work with new CLI ([#150](#150)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Acquire token by calling
databricksCLI. Incorporate detection to see if the path resolves to the Python CLI (< 0.100) or the new CLI (>= 0.100). This detection looks at the binary size to determine which one we're working with.Tests
Performed manual tests to confirm this credential provider works, even if the legacy CLI is present in
$PATHbefore the new CLI (by installing it in a venv and confirming that the SDK still uses the CLI credential provider).make testrun locallymake fmtapplied