[PROD-37531] Exposing REPL credential provider to Python SDK #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 53.01% 53.00% -0.01%
==========================================
Files 29 29
Lines 17568 17570 +2
==========================================
Hits 9313 9313
- Misses 8255 8257 +2
☔ View full report in Codecov by Sentry. |
nfx
suggested changes
May 31, 2023
| @@ -6,7 +6,8 @@ | |||
| # available to be imported from databricks.sdk.runtime.globals. This import can be used | |||
| # in Python modules so users can access these objects from Files more easily. | |||
| dbruntime_objects = [ | |||
| "display", "displayHTML", "dbutils", "table", "sql", "udf", "getArgument", "sc", "sqlContext", "spark" | |||
| "display", "displayHTML", "dbutils", "table", "sql", "udf", "getArgument", "sc", "sqlContext", "spark", | |||
| "init_runtime_native_auth" | |||
There was a problem hiding this comment.
what happens if init_runtime_native_auth is not present in the userNamespaceGlobals in the old DBR versions? please add if var not in userNamespaceGlobals: continue, otherwise SDK might crash
There was a problem hiding this comment.
@nfx I will add it. However, when I test this against DBR 12.2 LTS (which definitely doesn't have init_runtime_native_auth), it doesn't actually crash. That is surprising considering that if I run this in notebook, it raise a KeyError as expected. Do you have any idea why this is the case? Just curious.
nfx
approved these changes
Jun 1, 2023
| @@ -6,7 +6,8 @@ | |||
| # available to be imported from databricks.sdk.runtime.globals. This import can be used | |||
| # in Python modules so users can access these objects from Files more easily. | |||
| dbruntime_objects = [ | |||
| "display", "displayHTML", "dbutils", "table", "sql", "udf", "getArgument", "sc", "sqlContext", "spark" | |||
| "display", "displayHTML", "dbutils", "table", "sql", "udf", "getArgument", "sc", "sqlContext", "spark", | |||
| "init_runtime_native_auth" | |||
Merged
nfx
added a commit
that referenced
this pull request
Jun 9, 2023
# Version changelog ## 0.1.9 * Added new services from OpenAPI spec ([#145](#145), [#159](#159)). * Added consistent usage of the `upload(path, IO)` and `download(path) -> IO` across file-related operations ([#148](#148)). * Added Databricks Metadata Service credential provider ([#139](#139), [#130](#130)). * Added exposing runtime credential provider without changing user namespace ([#140](#140)). * Added a check for `is not None` for primitive fields in `as_dict()` ([#147](#147)). * Fixed bug related to boolean flags and convert `True` to `true` in query strings ([#156](#156)). * Fixed generation of external entities ([#146](#146)). * Make u2m authentication work with new CLI ([#150](#150)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In previous PR, we expose a function that will be used by Python SDK's
runtime_native_authso that in notebook environment it directly access information from command execution to authenticate. This PR import it from Python runtime to put on last piece of puzzle.Tests
make testrun locallymake fmtapplied