Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Run AccountClientIT test only for aws-prod-ucacct #311

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

tanmay-db
Copy link
Contributor

@tanmay-db tanmay-db commented Jul 12, 2024

Changes

Non-UC workspaces do not support adding SP. This is currently blocking the release pipeline due to a failing test in our integration tests. To unblock released we are only going to run this test in aws-prod-ucacct

Tests

Manually ran this test locally on ucacct and it passed
Also ran nightly over the which passed for aws-prod-acct

@tanmay-db tanmay-db changed the title Run AccountClientIT test only for aws-prod-ucacct Run AccountClientIT test only for aws-prod-ucacct Jul 12, 2024
@tanmay-db tanmay-db requested a review from mgyucht July 12, 2024 11:48
@tanmay-db tanmay-db changed the title Run AccountClientIT test only for aws-prod-ucacct [Internal] Run AccountClientIT test only for aws-prod-ucacct Jul 12, 2024
@tanmay-db tanmay-db added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit 043c306 Jul 12, 2024
10 checks passed
@tanmay-db tanmay-db deleted the fix-integration-test branch July 12, 2024 13:05
@tanmay-db tanmay-db mentioned this pull request Jul 12, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 12, 2024
## 0.27.1

### New Features and Improvements
* Specify proxy auth explicitly when using system proxy
([#300](#300)).
* Accept any `HttpRequest` instead of `HttpUriRequest` in
`CommonHttpClient`
([#305](#305)).
* Add credential provider for Azure Github OIDC
([#307](#307)).

### Internal Changes
* Add Release tag and Workflow Fix
([#309](#309)).
* Improve Changelog by grouping changes
([#308](#308)).
* Test parsing of error messages with `int` error codes
([#303](#303)).
* Run AccountClientIT test only for aws-prod-ucacct
([#311](#311)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants